[coreboot-gerrit] Patch merged into coreboot/master: ddf54b1 util/sconfig: fix check for count of command line arguments
gerrit at coreboot.org
gerrit at coreboot.org
Wed Jul 30 13:16:56 CEST 2014
the following patch was just integrated into master:
commit ddf54b1c8b2ef6e8e3d2a673e0dd1ab43c7edc2c
Author: Daniele Forsi <dforsi at gmail.com>
Date: Sun Jul 27 11:02:15 2014 +0200
util/sconfig: fix check for count of command line arguments
Valid invocations are when -s|b|k outputfile is missing (argc == 3)
and when it is followed by the file name (argc == 5); it's an error
when "outputfile" is missing (argc == 4) or when there are more
arguments than expected (argc > 5).
Fixes "Uninitialized argument value" error found by scan-build from
clang version 3.2-11.
Change-Id: I8c489863323eb60cbaa5e82a80f5d78a6ca893c2
Signed-off-by: Daniele Forsi <dforsi at gmail.com>
Reviewed-on: http://review.coreboot.org/6378
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>
Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
See http://review.coreboot.org/6378 for details.
-gerrit
More information about the coreboot-gerrit
mailing list