[coreboot-gerrit] New patch to review for coreboot: c31f892 peppy: Force enable ASPM on PCIe Root Port 1

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Wed Jul 30 21:25:18 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6419

-gerrit

commit c31f8920503d37274c21e156a34c42648314bd85
Author: Shawn Nematbakhsh <shawnn at chromium.org>
Date:   Wed Aug 21 11:47:11 2013 -0700

    peppy: Force enable ASPM on PCIe Root Port 1
    
    (Clone of Falco change Ie2111e4bb70411aa697dc63c0c11f13fbe66c8d8)
    
    Old-Change-Id: I5feba8fdbafba6d2de9f7d3de6170defc0d45a32
    Signed-off-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/66536
    Reviewed-by: Dave Parker <dparker at chromium.org>
    (cherry picked from commit b78a872a6647d7bb82f6c06a75e4075e451a1622)
    
    peppy: Disable unused clocks
    
    CLKOUT for PCIE ports 2-5 and CLKOUT_XDP are not used
    and can be disabled.
    
    This change was modled after the change made in Falco:
    Falco-Change-Id: I0f996e90f0ae42780de3a0c8dc5db00ec600748b
    
    The only difference per schematic for Peppy was PCIe 1 supports
    a NGFF interface. PCIe 0 is connected to WLAN.
    
    Old-Change-Id: Ib4871cb2655316cb260ab33ada6b9d81f271377f
    Signed-off-by: Steven Sherk <steven.sherk at se-eng.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/66693
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Tested-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Commit-Queue: Shawn Nematbakhsh <shawnn at chromium.org>
    (cherry picked from commit 8f12335013a510dee3c21b55251ab00c0fbac609)
    
    Squashed two related commits.
    
    Change-Id: Ibc5b902018eec07fdccaa8c6cb066ce918f6a6b5
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/mainboard/google/peppy/devicetree.cb | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/mainboard/google/peppy/devicetree.cb b/src/mainboard/google/peppy/devicetree.cb
index b19f04b..4c0d02d 100644
--- a/src/mainboard/google/peppy/devicetree.cb
+++ b/src/mainboard/google/peppy/devicetree.cb
@@ -78,6 +78,12 @@ chip northbridge/intel/haswell
 			register "sio_i2c0_voltage" = "0" # 3.3V
 			register "sio_i2c1_voltage" = "0" # 3.3V
 
+			# Force enable ASPM for PCIe Port1
+			register "pcie_port_force_aspm" = "0x01"
+
+			# Disable PCIe CLKOUT 2-5 and CLKOUT_XDP
+			register "icc_clock_disable" = "0x013c0000"
+
 			device pci 13.0 off end # Smart Sound Audio DSP
 			device pci 14.0 on end # USB3 XHCI
 			device pci 15.0 on end # Serial I/O DMA



More information about the coreboot-gerrit mailing list