[coreboot-gerrit] Patch set updated for coreboot: 067c6bf drivers: Add missing header guards

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Thu Jul 31 09:45:28 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6421

-gerrit

commit 067c6bf6081b78116ae86e486341cdd5efc741ab
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Thu Jul 31 16:58:49 2014 +1000

    drivers: Add missing header guards
    
    Change-Id: I1fe93ac080aea75229fa55eb828149b6c0d3a52d
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/drivers/ati/ragexl/atyfb.h      | 5 +++++
 src/drivers/i2c/at24rf08c/lenovo.h  | 5 +++++
 src/drivers/i2c/rtd2132/chip.h      | 5 +++++
 src/drivers/i2c/w83793/chip.h       | 5 +++++
 src/drivers/ics/954309/chip.h       | 5 +++++
 src/drivers/intel/gma/edid.h        | 5 +++++
 src/drivers/intel/gma/i915.h        | 5 +++++
 src/drivers/lenovo/lenovo.h         | 5 +++++
 src/drivers/lenovo/wacom.c          | 3 ++-
 src/drivers/net/ns8390.h            | 5 +++++
 src/drivers/xpowers/axp209/axp209.h | 5 +++++
 11 files changed, 52 insertions(+), 1 deletion(-)

diff --git a/src/drivers/ati/ragexl/atyfb.h b/src/drivers/ati/ragexl/atyfb.h
index 94f31fe..c0e57be 100644
--- a/src/drivers/ati/ragexl/atyfb.h
+++ b/src/drivers/ati/ragexl/atyfb.h
@@ -2,6 +2,9 @@
  *  ATI Frame Buffer Device Driver Core Definitions
  */
 
+#ifndef AFYFB_H
+#define AFYFB_H
+
 #define PLL_CRTC_DECODE 0
 
 #define EINVAL -1
@@ -405,3 +408,5 @@ extern const struct display_switch fbcon_aty16;
 extern const struct display_switch fbcon_aty24;
 extern const struct display_switch fbcon_aty32;
 #endif
+
+#endif /* AFYFB_H */
diff --git a/src/drivers/i2c/at24rf08c/lenovo.h b/src/drivers/i2c/at24rf08c/lenovo.h
index 6824eb6..aaf9387 100644
--- a/src/drivers/i2c/at24rf08c/lenovo.h
+++ b/src/drivers/i2c/at24rf08c/lenovo.h
@@ -1 +1,6 @@
+#ifndef AT24RF08C_LENOVO_H
+#define AT24RF08C_LENOVO_H
+
 const char *lenovo_mainboard_partnumber(void);
+
+#endif /* AT24RF08C_LENOVO_H */
diff --git a/src/drivers/i2c/rtd2132/chip.h b/src/drivers/i2c/rtd2132/chip.h
index 2cf0827..f6f2b70 100644
--- a/src/drivers/i2c/rtd2132/chip.h
+++ b/src/drivers/i2c/rtd2132/chip.h
@@ -17,6 +17,9 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA, 02110-1301 USA
  */
 
+#ifndef CHIP_H
+#define CHIP_H
+
 struct drivers_i2c_rtd2132_config {
 	/* Panel Power Sequencing. All units in ms. */
 	u16 t1; /* Delay from panel Vcc enable to LVDS output enable. */
@@ -49,3 +52,5 @@ struct drivers_i2c_rtd2132_config {
 	 */
 	u8 sscg_percent;
 };
+
+#endif /* CHIP_H */
diff --git a/src/drivers/i2c/w83793/chip.h b/src/drivers/i2c/w83793/chip.h
index 65a50bb..c1d1bd9 100644
--- a/src/drivers/i2c/w83793/chip.h
+++ b/src/drivers/i2c/w83793/chip.h
@@ -1,3 +1,6 @@
+#ifndef CHIP_H
+#define CHIP_H
+
 struct drivers_i2c_w83793_config {
 	u8 mfc;
 	u8 fanin;
@@ -17,3 +20,5 @@ struct drivers_i2c_w83793_config {
 	u8 tr1_fan_select;
 	u8 tr2_fan_select;
 };
+
+#endif /* CHIP_H */
diff --git a/src/drivers/ics/954309/chip.h b/src/drivers/ics/954309/chip.h
index 66cc2c6..807185a 100644
--- a/src/drivers/ics/954309/chip.h
+++ b/src/drivers/ics/954309/chip.h
@@ -19,6 +19,9 @@
  * MA 02110-1301 USA
  */
 
+#ifndef CHIP_H
+#define CHIP_H
+
 struct drivers_ics_954309_config {
 	u8 reg0;
 	u8 reg1;
@@ -33,3 +36,5 @@ struct drivers_ics_954309_config {
 	u8 reg10;
 	u8 reg11;
 };
+
+#endif /* CHIP_H */
diff --git a/src/drivers/intel/gma/edid.h b/src/drivers/intel/gma/edid.h
index cb54b46..8f090b1 100644
--- a/src/drivers/intel/gma/edid.h
+++ b/src/drivers/intel/gma/edid.h
@@ -1 +1,6 @@
+#ifndef INTEL_GMA_EDID_H
+#define INTEL_GMA_EDID_H
+
 void intel_gmbus_read_edid(u32 gmbus_mmio, u8 bus, u8 slave, u8 *edid, u32 edid_size);
+
+#endif /* INTEL_GMA_EDID_H */
diff --git a/src/drivers/intel/gma/i915.h b/src/drivers/intel/gma/i915.h
index 9ef3abd..9e441ee 100644
--- a/src/drivers/intel/gma/i915.h
+++ b/src/drivers/intel/gma/i915.h
@@ -17,6 +17,9 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#ifndef I915_H
+#define I915_H
+
 #include <drivers/intel/gma/i915_reg.h>
 #include <drivers/intel/gma/drm_dp_helper.h>
 #include <edid.h>
@@ -262,3 +265,5 @@ int intel_dp_get_lane_count(struct intel_dp *intel_dp,
 
 int intel_dp_get_lane_align_status(struct intel_dp *intel_dp,
 				   u8 *recv);
+
+#endif /* I915_H */
diff --git a/src/drivers/lenovo/lenovo.h b/src/drivers/lenovo/lenovo.h
index 4c44119..2e1fe77 100644
--- a/src/drivers/lenovo/lenovo.h
+++ b/src/drivers/lenovo/lenovo.h
@@ -1,3 +1,8 @@
+#ifndef LENOVO_H
+#define LENOVO_H
+
 int drivers_lenovo_is_wacom_present(void);
 void drivers_lenovo_serial_ports_ssdt_generate(const char *scope,
 					       int have_dock_serial);
+
+#endif /* LENOVO_H */
diff --git a/src/drivers/lenovo/wacom.c b/src/drivers/lenovo/wacom.c
index 33a2879..2fab858 100644
--- a/src/drivers/lenovo/wacom.c
+++ b/src/drivers/lenovo/wacom.c
@@ -26,8 +26,9 @@
 #include <device/device.h>
 #include <device/pnp.h>
 #include <string.h>
+#include <drivers/i2c/at24rf08c/lenovo.h>
+
 #include "lenovo.h"
-#include "drivers/i2c/at24rf08c/lenovo.h"
 
 static const char tablet_numbers[][5] = {
 	/* X60t. */
diff --git a/src/drivers/net/ns8390.h b/src/drivers/net/ns8390.h
index 23a68a0..d30b54d 100644
--- a/src/drivers/net/ns8390.h
+++ b/src/drivers/net/ns8390.h
@@ -1,3 +1,6 @@
+#ifndef NS8390_H
+#define NS8390_H
+
 /**************************************************************************
 ETHERBOOT -  BOOTP/TFTP Bootstrap Program
 
@@ -107,3 +110,5 @@ struct ringbuffer {
  *  c-basic-offset: 8
  * End:
  */
+
+#endif /* NS8390_H */
diff --git a/src/drivers/xpowers/axp209/axp209.h b/src/drivers/xpowers/axp209/axp209.h
index c9cdd7e..960e3d2 100644
--- a/src/drivers/xpowers/axp209/axp209.h
+++ b/src/drivers/xpowers/axp209/axp209.h
@@ -5,6 +5,9 @@
  * Subject to the GNU GPL v2, or (at your option) any later version.
  */
 
+#ifndef AXP209_H
+#define AXP209_H
+
 #include <types.h>
 #include "chip.h"
 
@@ -18,3 +21,5 @@ enum cb_err axp209_set_ldo3_voltage(u8 bus, u16 millivolts);
 enum cb_err axp209_set_ldo4_voltage(u8 bus, u16 millivolts);
 enum cb_err axp209_set_voltages(u8 bus, const struct
 				drivers_xpowers_axp209_config *cfg);
+
+#endif /* AXP209_H */



More information about the coreboot-gerrit mailing list