[coreboot-gerrit] New patch to review for coreboot: d49da35 mainboard/supermicro/h8dme: Drop unused code

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Fri Jun 6 07:38:06 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5942

-gerrit

commit d49da356f6b3e99c1d21f9d220a07e69ff44ffd4
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Jun 6 08:32:42 2014 +0300

    mainboard/supermicro/h8dme: Drop unused code
    
    Clang complains about a unused debug function, so remove dead code.
    We have copy of dump_smbus_registers() in amdk8/debug.c.
    
    Change-Id: Ibf46deb1de1589d81760841b1d4ba319707915aa
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/supermicro/h8dme/romstage.c | 31 +++----------------------------
 1 file changed, 3 insertions(+), 28 deletions(-)

diff --git a/src/mainboard/supermicro/h8dme/romstage.c b/src/mainboard/supermicro/h8dme/romstage.c
index 7763480..e3e7386 100644
--- a/src/mainboard/supermicro/h8dme/romstage.c
+++ b/src/mainboard/supermicro/h8dme/romstage.c
@@ -45,33 +45,6 @@
 
 static void memreset(int controllers, const struct mem_controller *ctrl) { }
 
-static inline void dump_smbus_registers(void)
-{
-	u32 device;
-
-	print_debug("\n");
-	for (device = 1; device < 0x80; device++) {
-		int j;
-		if (smbus_read_byte(device, 0) < 0)
-			continue;
-		printk(BIOS_DEBUG, "smbus: %02x", device);
-		for (j = 0; j < 256; j++) {
-			int status;
-			unsigned char byte;
-			status = smbus_read_byte(device, j);
-			if (status < 0) {
-				break;
-			}
-			if ((j & 0xf) == 0) {
-				printk(BIOS_DEBUG, "\n%02x: ", j);
-			}
-			byte = status & 0xff;
-			printk(BIOS_DEBUG, "%02x ", byte);
-		}
-		print_debug("\n");
-	}
-}
-
 static inline void activate_spd_rom(const struct mem_controller *ctrl)
 {
 #if 0
@@ -178,7 +151,9 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 	print_debug("\n");
 
 	set_sysinfo_in_ram(0);	// in BSP so could hold all ap until sysinfo is in ram
-/*	dump_smbus_registers(); */
+#if CONFIG_DEBUG_SMBUS
+	dump_smbus_registers();
+#endif
 	setup_coherent_ht_domain();	// routing table and start other core0
 
 	wait_all_core0_started();



More information about the coreboot-gerrit mailing list