[coreboot-gerrit] Patch set updated for coreboot: e69a4e1 lenovo/x60/i915.c: Log `PGETBL_CTL` programming

[Paul Menzel (paulepanter@users.sourceforge.net)]

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5934

-gerrit

commit e69a4e11fce01a088b98348bbadd225be930e9a7
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Thu Jun 5 09:38:39 2014 +0200

    lenovo/x60/i915.c: Log `PGETBL_CTL` programming
    
    Correctly setting up `PGETBL_CTL` is essential for the operating
    system driver to work correctly. Therefore log it more verbosely.
    
    Change-Id: I9b3dfa52f91c13e768c2ef980e5871173a85fcfe
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/lenovo/x60/i915.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index 016217f..95b836a 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -141,13 +141,16 @@ int gtt_setup(unsigned int mmiobase)
 
 	write32(mmiobase + GFX_FLSH_CNTL, 0);
 
+	printk(BIOS_DEBUG, "%s: Write %lx to PGETBL_CTL ...", __func__, pgetbl_ctl);
 	write32(mmiobase + PGETBL_CTL, pgetbl_ctl);
 
 	/* verify */
-	if (read32(mmiobase + PGETBL_CTL) & PGETBL_ENABLED) {
-		printk(BIOS_DEBUG, "gtt_setup is enabled.\n");
+	pgetbl_ctl = read32(mmiobase + PGETBL_CTL);
+	printk(BIOS_DEBUG, " read back %lx ...", pgetbl_ctl);
+	if (pgetbl_ctl & PGETBL_ENABLED) {
+		printk(BIOS_DEBUG, " GM mappings enabled ... GTT setup successful.\n");
 	} else {
-		printk(BIOS_DEBUG, "gtt_setup failed!!!\n");
+		printk(BIOS_DEBUG, " GM mappings disabled ... GTT setup failed.\n");
 		return 1;
 	}
 	write32(mmiobase + GFX_FLSH_CNTL, 0);