[coreboot-gerrit] Patch set updated for coreboot: ad58cea amd/hudson: Add the IOAPIC space to the fixed resources table

Dave Frodin (dave.frodin@se-eng.com) gerrit at coreboot.org
Mon Jun 9 20:47:10 CEST 2014


Dave Frodin (dave.frodin at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5946

-gerrit

commit ad58cea2270837ba7ab603731a65a44b4375a072
Author: Dave Frodin <dave.frodin at se-eng.com>
Date:   Thu Jun 5 14:21:11 2014 -0600

    amd/hudson: Add the IOAPIC space to the fixed resources table
    
    Without this change the IOAPIC memory window would collide
    with PCI config space. This was tested on the hp/abm board.
    
    Change-Id: I5dd53463961f75bab80a41dc7beff8d0434b24ae
    Signed-off-by: Dave Frodin <dave.frodin at se-eng.com>
---
 src/southbridge/amd/agesa/hudson/lpc.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/southbridge/amd/agesa/hudson/lpc.c b/src/southbridge/amd/agesa/hudson/lpc.c
index a0dc072..71aaf6f 100644
--- a/src/southbridge/amd/agesa/hudson/lpc.c
+++ b/src/southbridge/amd/agesa/hudson/lpc.c
@@ -2,6 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2010 Advanced Micro Devices, Inc.
+ * Copyright (C) 2014 Sage Electronic Engineering, LLC
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -27,6 +28,7 @@
 #include <pc80/mc146818rtc.h>
 #include <pc80/isa-dma.h>
 #include <arch/io.h>
+#include <arch/ioapic.h>
 #include "hudson.h"
 
 static void lpc_init(device_t dev)
@@ -100,10 +102,10 @@ static void hudson_lpc_read_resources(device_t dev)
 	res->flags = IORESOURCE_MEM | IORESOURCE_SUBTRACTIVE |
 		     IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 
-	//res = new_resource(dev, 3); /* IOAPIC */
-	//res->base = 0xfec00000;
-	//res->size = 0x00001000;
-	//res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
+	res = new_resource(dev, 3); /* IOAPIC */
+	res->base = IO_APIC_ADDR;
+	res->size = 0x00001000;
+	res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 
 	compact_resources(dev);
 }



More information about the coreboot-gerrit mailing list