[coreboot-gerrit] New patch to review for coreboot: c97997c lippert/frontrunner-af: Fix comment on HAVE_ACPI_RESUME

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Wed Jun 11 12:50:13 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5970

-gerrit

commit c97997ccd0a67caa2105728cee7659d8d0efe8ea
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Jun 6 22:57:01 2014 +0300

    lippert/frontrunner-af: Fix comment on HAVE_ACPI_RESUME
    
    S3 resume now works, however the 3s delay and flash wear is still there.
    
    Change-Id: I9d2eda5454baf7704807cf67f3aca94a67de3406
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/lippert/frontrunner-af/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig b/src/mainboard/lippert/frontrunner-af/Kconfig
index d3ac3f9..e534dc9 100644
--- a/src/mainboard/lippert/frontrunner-af/Kconfig
+++ b/src/mainboard/lippert/frontrunner-af/Kconfig
@@ -28,9 +28,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_OPTION_TABLE
 	select HAVE_PIRQ_TABLE
 	select HAVE_MP_TABLE
-	# S3 doesn't work yet, heapManager.c:576 failed last time I tried,
-	# couldn't figure out why.  But s3_resume.c (look for "spi_flash_probe")
-	# erases 28 KB and writes 10 KB register dumps to SPI flash on every
+	# This erases 28 KB and writes 10 KB register dumps to SPI flash on every
 	# boot, wasting 3 s and causing wear!  Therefore disable S3 for now.
 	#select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES



More information about the coreboot-gerrit mailing list