[coreboot-gerrit] New patch to review for coreboot: 68a28a2 intel/model_2065x: Remove dead code.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Wed Jun 11 23:31:27 CEST 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5975

-gerrit

commit 68a28a2ebc497f176a36aab5cae28fd4ae79b832
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Wed Jun 11 18:52:11 2014 +0000

    intel/model_2065x: Remove dead code.
    
    nehalem uses gm45-like approach to resume backup so this code is never
    used.
    
    Change-Id: Ic32aa73f8d5b164b1c57815f6f44b2732fdbdcdb
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/cpu/intel/model_2065x/cache_as_ram.inc | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/src/cpu/intel/model_2065x/cache_as_ram.inc b/src/cpu/intel/model_2065x/cache_as_ram.inc
index e46a2ee..21f626b 100644
--- a/src/cpu/intel/model_2065x/cache_as_ram.inc
+++ b/src/cpu/intel/model_2065x/cache_as_ram.inc
@@ -274,27 +274,6 @@ before_romstage:
 
 	post_code(0x3c)
 
-#if CONFIG_HAVE_ACPI_RESUME
-	movl	CBMEM_BOOT_MODE, %eax
-	cmpl	$0x2, %eax // Resume?
-	jne	__acpi_resume_backup_done
-
-	/* copy 1MB - 64K to high tables ram_base to prevent memory corruption
-	 * through stage 2. We could keep stuff like stack and heap in high
-	 * tables memory completely, but that's a wonderful clean up task for
-	 * another day.
-	 */
-	cld
-	movl	$CONFIG_RAMBASE, %esi
-	movl	CBMEM_RESUME_BACKUP, %edi
-	movl	$HIGH_MEMORY_SAVE / 4, %ecx
-	rep	movsl
-
-__acpi_resume_backup_done:
-#endif
-
-	post_code(0x3d)
-
 __main:
 	post_code(POST_PREPARE_RAMSTAGE)
 	cld			/* Clear direction flag. */



More information about the coreboot-gerrit mailing list