[coreboot-gerrit] Patch merged into coreboot/master: b57fef9 src/ec: Sanitize headers and comment #endif pairings

gerrit at coreboot.org gerrit at coreboot.org
Wed Jun 25 11:34:10 CEST 2014


the following patch was just integrated into master:
commit b57fef9f3e2b3cb8d8c8c5a3552c94a28ff81d15
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Jun 17 20:13:08 2014 +1000

    src/ec: Sanitize headers and comment #endif pairings
    
    Comment #endif /* FOO */ pairings.
    Alphabetise headers and remove any #if CONFIG_ guards around them.
    
    Background rational:
    Remove guarding the inclusion of headers based on CONFIG_ options. This
    *potentially* could hide issues such as functions being swapped from
    under our feet, since different runtime behaviour could be declared with
    the same function same name and type-signature. Hence, depending on the
    header we happen to get may change runtime behaviour.
    
    Change-Id: Ic61bdfb64d99f0e2998c6451ae6686915b7bb3d4
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Reviewed-on: http://review.coreboot.org/6059
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>


See http://review.coreboot.org/6059 for details.

-gerrit



More information about the coreboot-gerrit mailing list