[coreboot-gerrit] New patch to review for coreboot: bacc487 libpayload/libc/hexdump.c: Take `const void *memory` as argument

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Mar 24 01:28:31 CET 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5403

-gerrit

commit bacc48762d8cedb5ed028379e9d86931c79515cc
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Mar 24 00:42:36 2014 +0100

    libpayload/libc/hexdump.c: Take `const void *memory` as argument
    
    `*memory` is not changed in `hexdump()` and just read so make it
    `const`.
    
    Change-Id: I9504d25ab5c785f05c39c9a4f48c21f68659a829
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 payloads/libpayload/include/libpayload.h | 2 +-
 payloads/libpayload/libc/hexdump.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h
index 8a0d915..e77c2af 100644
--- a/payloads/libpayload/include/libpayload.h
+++ b/payloads/libpayload/include/libpayload.h
@@ -294,7 +294,7 @@ long int labs(long int j);
 long long int llabs(long long int j);
 u8 bin2hex(u8 b);
 u8 hex2bin(u8 h);
-void hexdump(void *memory, size_t length);
+void hexdump(const void *memory, size_t length);
 void fatal(const char *msg) __attribute__ ((noreturn));
 /** @} */
 
diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c
index e33a306..d2953a5 100644
--- a/payloads/libpayload/libc/hexdump.c
+++ b/payloads/libpayload/libc/hexdump.c
@@ -29,7 +29,7 @@
 
 #include <libpayload.h>
 
-void hexdump(void *memory, size_t length)
+void hexdump(const void *memory, size_t length)
 {
 	int i;
 	uint8_t *m;



More information about the coreboot-gerrit mailing list