[coreboot-gerrit] New patch to review for coreboot: 9a10b32 amd/agesa/s3_resume: Make compiler agnostic.

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sun Mar 30 13:31:35 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5429

-gerrit

commit 9a10b32aa8198865e9eb1dd680aea448068d673d
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sun Mar 30 22:28:26 2014 +1100

    amd/agesa/s3_resume: Make compiler agnostic.
    
    Clang does not like inline functions defined in C files with prototypes
    in headers. Rather Clang expects inline function bodies to be in headers
    if they are to be used out of scope. Since inline is purely advisory to
    the compiler, drop its usage here.
    
    Change-Id: I08a7a3d2cdf841ffbab10c017c75917768aac209
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/cpu/amd/agesa/s3_resume.c | 2 +-
 src/cpu/amd/agesa/s3_resume.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/cpu/amd/agesa/s3_resume.c b/src/cpu/amd/agesa/s3_resume.c
index e056a18..7b1157d 100644
--- a/src/cpu/amd/agesa/s3_resume.c
+++ b/src/cpu/amd/agesa/s3_resume.c
@@ -103,7 +103,7 @@ void restore_mtrr(void)
 	wrmsr(SYS_CFG, msr_data);
 }
 
-inline void *backup_resume(void)
+void *backup_resume(void)
 {
 	void *resume_backup_memory;
 
diff --git a/src/cpu/amd/agesa/s3_resume.h b/src/cpu/amd/agesa/s3_resume.h
index 5ee4f38..6e719c9 100644
--- a/src/cpu/amd/agesa/s3_resume.h
+++ b/src/cpu/amd/agesa/s3_resume.h
@@ -41,7 +41,7 @@ typedef enum {
 
 void restore_mtrr(void);
 void s3_resume(void);
-inline void *backup_resume(void);
+void *backup_resume(void);
 void set_resume_cache(void);
 void move_stack_high_mem(void);
 



More information about the coreboot-gerrit mailing list