[coreboot-gerrit] New patch to review for coreboot: e09f16f lenovo/t60: Move mainboard_enable() code into a mainboard_init()

Trevor Mosey (uberushaximus@gmail.com) gerrit at coreboot.org
Sat May 3 03:10:39 CEST 2014


Trevor Mosey (uberushaximus at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5637

-gerrit

commit e09f16f2f1fb7c7fc5d38a8c51c468c6dbbe0857
Author: Trevor Mosey <uberushaximus at gmail.com>
Date:   Fri May 2 16:11:50 2014 -0500

    lenovo/t60: Move mainboard_enable() code into a mainboard_init()
    
    mainboard_enable() is now modelled after google/parrot where the
    enable function only sets dev->ops->init for the root device to
    point to a mainboard_init() function, which in turn is called in a
    later pass over the device tree to do the actual initialization.
    
    Change-Id: I89a5192bd45ca8321b2b1ac49b073122e0f6ee2b
    Signed-off-by: Trevor Mosey <uberushaximus at gmail.com>
---
 src/mainboard/lenovo/t60/mainboard.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/lenovo/t60/mainboard.c b/src/mainboard/lenovo/t60/mainboard.c
index bfdbef6..623031a 100644
--- a/src/mainboard/lenovo/t60/mainboard.c
+++ b/src/mainboard/lenovo/t60/mainboard.c
@@ -46,7 +46,7 @@ int get_cst_entries(acpi_cstate_t **entries)
 	return ARRAY_SIZE(cst_entries);
 }
 
-static void mainboard_enable(device_t dev)
+static void mainboard_init(device_t dev)
 {
 	struct southbridge_intel_i82801gx_config *config;
 	device_t dev0, idedev;
@@ -78,6 +78,11 @@ static void mainboard_enable(device_t dev)
 	ec_write(0x0c, inb(0x164c) & 8 ? 0x89 : 0x09);
 }
 
+static void mainboard_enable(device_t dev)
+{
+	dev->ops->init = mainboard_init;
+}
+
 struct chip_operations mainboard_ops = {
 	.enable_dev = mainboard_enable,
 };



More information about the coreboot-gerrit mailing list