[coreboot-gerrit] New patch to review for coreboot: f117a03 ChromeOS boards: Use explicit include of chromeos.c

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sat May 3 12:00:56 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5640

-gerrit

commit f117a0357ac80c42626040c668d9cc6a1eef4a0b
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Apr 28 23:41:06 2014 +0300

    ChromeOS boards: Use explicit include of chromeos.c
    
    Change-Id: I7b3d044fad1d6973910e9bef347478a45c149a4f
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/intel/emeraldlake2/Makefile.inc | 21 +++++++++++++++++++++
 src/mainboard/samsung/lumpy/Makefile.inc      |  5 ++++-
 src/mainboard/samsung/stumpy/Makefile.inc     | 21 +++++++++++++++++++++
 src/vendorcode/google/chromeos/Makefile.inc   |  4 ----
 4 files changed, 46 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/intel/emeraldlake2/Makefile.inc b/src/mainboard/intel/emeraldlake2/Makefile.inc
new file mode 100644
index 0000000..c595a62
--- /dev/null
+++ b/src/mainboard/intel/emeraldlake2/Makefile.inc
@@ -0,0 +1,21 @@
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2012 Google Inc.
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 2 of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+##
+
+romstage-$(CONFIG_CHROMEOS) += chromeos.c
+ramstage-$(CONFIG_CHROMEOS) += chromeos.c
diff --git a/src/mainboard/samsung/lumpy/Makefile.inc b/src/mainboard/samsung/lumpy/Makefile.inc
index bb412ce..4c6d647 100644
--- a/src/mainboard/samsung/lumpy/Makefile.inc
+++ b/src/mainboard/samsung/lumpy/Makefile.inc
@@ -1,7 +1,7 @@
 ##
 ## This file is part of the coreboot project.
 ##
-## Copyright (C) 2011 The ChromiumOS Authors.  All rights reserved.
+## Copyright (C) 2012 Google Inc.
 ##
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -19,6 +19,9 @@
 
 ramstage-y += ec.c
 
+romstage-$(CONFIG_CHROMEOS) += chromeos.c
+ramstage-$(CONFIG_CHROMEOS) += chromeos.c
+
 SPD_BIN = $(obj)/spd.bin
 
 # Include spd rom data
diff --git a/src/mainboard/samsung/stumpy/Makefile.inc b/src/mainboard/samsung/stumpy/Makefile.inc
new file mode 100644
index 0000000..c595a62
--- /dev/null
+++ b/src/mainboard/samsung/stumpy/Makefile.inc
@@ -0,0 +1,21 @@
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2012 Google Inc.
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 2 of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+##
+
+romstage-$(CONFIG_CHROMEOS) += chromeos.c
+ramstage-$(CONFIG_CHROMEOS) += chromeos.c
diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.inc
index 21e1750..4eb3817 100644
--- a/src/vendorcode/google/chromeos/Makefile.inc
+++ b/src/vendorcode/google/chromeos/Makefile.inc
@@ -27,10 +27,6 @@ romstage-y += fmap.c
 ramstage-y += fmap.c
 ramstage-$(CONFIG_CHROMEOS_RAMOOPS) += ramoops.c
 smm-y += fmap.c
-ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/chromeos.c),)
-ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/chromeos.c
-romstage-srcs += src/mainboard/$(MAINBOARDDIR)/chromeos.c
-endif
 
 ifeq ($(MOCK_TPM),1)
 CFLAGS += -DMOCK_TPM=1



More information about the coreboot-gerrit mailing list