[coreboot-gerrit] Patch set updated for coreboot: 10f678d lib/hexdump.c: Indent with tabs instead of spaces and remove empty lines

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat May 3 16:35:59 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4576

-gerrit

commit 10f678d99eae00668e36a602adfb973a41a6a7b1
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Dec 27 14:43:44 2013 +0100

    lib/hexdump.c: Indent with tabs instead of spaces and remove empty lines
    
    The coding style requires to use tabs for indentation and not spaces.
    Use GNU indent 2.2.11 with the switch `-linux` to indent the file,
    which also removes the empty lines at the end of the file.
    
    Change-Id: I874f178e50d7558d3299026aec2771ad45f88d8e
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/lib/hexdump.c | 62 +++++++++++++++++++++++++++----------------------------
 1 file changed, 31 insertions(+), 31 deletions(-)

diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c
index 6100920..2624333 100644
--- a/src/lib/hexdump.c
+++ b/src/lib/hexdump.c
@@ -28,54 +28,54 @@ static int isprint(int c)
 	return (c >= 32 && c <= 126);
 }
 
-void hexdump(const void* memory, size_t length)
+void hexdump(const void *memory, size_t length)
 {
-        int i;
-        uint8_t *m;
-        int all_zero = 0;
+	int i;
+	uint8_t *m;
+	int all_zero = 0;
 
-        m = (uint8_t *)memory;
+	m = (uint8_t *) memory;
 
-        for (i = 0; i < length; i += 16) {
-                int j;
+	for (i = 0; i < length; i += 16) {
+		int j;
 
-                all_zero++;
-                for (j = 0; j < 16; j++) {
-                        if(m[i+j] != 0) {
-                                all_zero = 0;
-                                break;
-                        }
-                }
+		all_zero++;
+		for (j = 0; j < 16; j++) {
+			if (m[i + j] != 0) {
+				all_zero = 0;
+				break;
+			}
+		}
 
-                if (all_zero < 2) {
-                        printk(BIOS_DEBUG, "%p:", memory + i);
-                        for (j = 0; j < 16; j++)
-                                printk(BIOS_DEBUG, " %02x", m[i+j]);
-                        printk(BIOS_DEBUG, "  ");
-                        for (j = 0; j < 16; j++)
-                                printk(BIOS_DEBUG, "%c",
-					isprint(m[i+j]) ? m[i+j] : '.');
-                        printk(BIOS_DEBUG, "\n");
-                } else if (all_zero == 2) {
-                        printk(BIOS_DEBUG, "...\n");
-                }
-        }
+		if (all_zero < 2) {
+			printk(BIOS_DEBUG, "%08lx:", memory + i);
+			for (j = 0; j < 16; j++)
+				printk(BIOS_DEBUG, " %02x", m[i + j]);
+			printk(BIOS_DEBUG, "  ");
+			for (j = 0; j < 16; j++)
+				printk(BIOS_DEBUG, "%c",
+				       isprint(m[i + j]) ? m[i + j] : '.');
+			printk(BIOS_DEBUG, "\n");
+		} else if (all_zero == 2) {
+			printk(BIOS_DEBUG, "...\n");
+		}
+	}
 }
 
 void hexdump32(char LEVEL, const void *d, int len)
 {
-	int count=0;
+	int count = 0;
 
 	while (len > 0) {
 		if (count % 8 == 0) {
-			printk(LEVEL,"\n");
+			printk(LEVEL, "\n");
 			printk(LEVEL, "%p:", d);
 		}
-		printk(LEVEL, " 0x%08lx", *(unsigned long*)d);
+		printk(LEVEL, " 0x%08lx", *(unsigned long *)d);
 		count++;
 		len--;
 		d += 4;
 	}
 
-	printk(LEVEL,"\n\n");
+	printk(LEVEL, "\n\n");
 }



More information about the coreboot-gerrit mailing list