[coreboot-gerrit] New patch to review for coreboot: 2f9e060 mainboard/jetway/nf81-t56n-lf: Disable ALIB SSDT in acpi_tables.c

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Mon May 5 20:54:28 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5665

-gerrit

commit 2f9e0603375ac91ca568c9d8c18e5e7ad9e51c0b
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue May 6 04:52:06 2014 +1000

    mainboard/jetway/nf81-t56n-lf: Disable ALIB SSDT in acpi_tables.c
    
    The ALIB SSDT found in AGESA is a binary blob compiled with the
    Microsoft DSDT compiler suite. It has in fact syntax errors and is
    invalid. Thus we disable building a image with it by default until this
    has been corrected in AGESA itself.
    
    Change-Id: If4b60122762bfa3a1a482d2374d6fb035fb4c1b4
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c b/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
index 63cdb52..23932fa 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
+++ b/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
@@ -232,9 +232,13 @@ unsigned long write_acpi_tables(unsigned long start)
 	}
 
 	/* SSDT */
-	current = ALIGN(current, 16);
-	printk(BIOS_DEBUG, "ACPI:  * AGESA ALIB SSDT at %lx\n", current);
-	alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
+//	current = ALIGN(current, 16);
+//	printk(BIOS_DEBUG, "ACPI:  * AGESA ALIB SSDT at %lx\n", current);
+//	alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
+	/* ALIB SSDT is a MS compiled blob inside AGESA that is broken with syntax
+	 * errors! We disable it for now. */
+	printk(BIOS_DEBUG, "ACPI:  * AGESA ALIB SSDT broken so disabled!\n");
+	alib = NULL;
 	if (alib != NULL) {
 		memcpy((void *)current, alib, alib->length);
 		alib = (acpi_header_t *) current;



More information about the coreboot-gerrit mailing list