[coreboot-gerrit] Patch set updated for coreboot: b8859cd rambi: fixup settings so trackpad can be found in kernel

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue May 6 18:41:55 CEST 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4970

-gerrit

commit b8859cda06178bc86e8406824c1d78ad572057bb
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Nov 13 14:31:16 2013 -0600

    rambi: fixup settings so trackpad can be found in kernel
    
    The kernel chromeos_laptop driver nomenclature expects the
    board name to not be in all caps. Fix this as well as the i2c
    address for the trackpad.
    
    BUG=chrome-os-partner:24307
    BRANCH=None
    TEST=Built and booted. trackpad device is found. IRQs still not
         working yet.
    
    Change-Id: Id6be8ee4bce2835e303ea4fe63944be80d2d7ec2
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/176680
    Reviewed-by: Shawn Nematbakhsh <shawnn at chromium.org>
---
 src/mainboard/google/rambi/Kconfig   | 2 +-
 src/mainboard/google/rambi/onboard.h | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig
index c0cb8ca..dc31541 100644
--- a/src/mainboard/google/rambi/Kconfig
+++ b/src/mainboard/google/rambi/Kconfig
@@ -23,7 +23,7 @@ config MAINBOARD_DIR
 
 config MAINBOARD_PART_NUMBER
 	string
-	default "RAMBI"
+	default "Rambi"
 
 config VGA_BIOS_FILE
 	string
diff --git a/src/mainboard/google/rambi/onboard.h b/src/mainboard/google/rambi/onboard.h
index 290f58c..6a8e751 100644
--- a/src/mainboard/google/rambi/onboard.h
+++ b/src/mainboard/google/rambi/onboard.h
@@ -25,13 +25,13 @@
 #define BOARD_TRACKPAD_NAME             "trackpad"
 #define BOARD_TRACKPAD_IRQ              GPIO_S0_DED_IRQ(TPAD_IRQ_OFFSET)
 #define BOARD_TRACKPAD_WAKE_GPIO        1       /* GPSSUS1 */
-#define BOARD_TRACKPAD_I2C_BUS          1       /* TODO(shawnn): Check this */
-#define BOARD_TRACKPAD_I2C_ADDR         0x67    /* TODO(shawnn): Check this */
+#define BOARD_TRACKPAD_I2C_BUS          0
+#define BOARD_TRACKPAD_I2C_ADDR         0x4b
 
 #define BOARD_TOUCHSCREEN_NAME          "touchscreen"
 #define BOARD_TOUCHSCREEN_IRQ           GPIO_S0_DED_IRQ(TOUCH_IRQ_OFFSET)
 #define BOARD_TOUCHSCREEN_WAKE_GPIO     2       /* GPSSUS2 */
-#define BOARD_TOUCHSCREEN_I2C_BUS       2       /* TODO(shawnn): Check this */
+#define BOARD_TOUCHSCREEN_I2C_BUS       5
 #define BOARD_TOUCHSCREEN_I2C_ADDR      0x4a    /* TODO(shawnn): Check this */
 
 #endif



More information about the coreboot-gerrit mailing list