[coreboot-gerrit] New patch to review for coreboot: dd40c28 Squelch some warnings from Kconfig

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu May 8 16:20:56 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5699

-gerrit

commit dd40c280d9487e03b0e885d6798afa0858a5d7e4
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Thu May 8 14:35:52 2014 +0300

    Squelch some warnings from Kconfig
    
    Overriding global config entries in mainboard directory Kconfig
    files often raise unnecessary warnings. Squelch some of those.
    
    Change-Id: Ib5127672ae068670028aa25c8ccb5366277622f2
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/hp/dl165_g6_fam10/Kconfig    | 5 +----
 src/mainboard/intel/cougar_canyon2/Kconfig | 5 +----
 src/mainboard/msi/ms9652_fam10/Kconfig     | 4 ----
 3 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/src/mainboard/hp/dl165_g6_fam10/Kconfig b/src/mainboard/hp/dl165_g6_fam10/Kconfig
index ba8c799..18b210e 100644
--- a/src/mainboard/hp/dl165_g6_fam10/Kconfig
+++ b/src/mainboard/hp/dl165_g6_fam10/Kconfig
@@ -17,6 +17,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select ENABLE_APIC_EXT_ID
 	select AMDMCT
 	select QRANK_DIMM_SUPPORT
+	select MMCONF_SUPPORT_DEFAULT
 
 config MAINBOARD_DIR
 	string
@@ -86,8 +87,4 @@ config BOOTBLOCK_MAINBOARD_INIT
 	string
 	default "mainboard/hp/dl165_g6_fam10/bootblock.c"
 
-config MMCONF_SUPPORT_DEFAULT
-	bool
-	default y
-
 endif # BOARD_HP_DL165_G6_FAM10
diff --git a/src/mainboard/intel/cougar_canyon2/Kconfig b/src/mainboard/intel/cougar_canyon2/Kconfig
index 774bbb8..cc263fd 100644
--- a/src/mainboard/intel/cougar_canyon2/Kconfig
+++ b/src/mainboard/intel/cougar_canyon2/Kconfig
@@ -14,6 +14,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select ENABLE_VMX
 	select EARLY_CBMEM_INIT
 	select BROKEN_CAR_MIGRATE
+	select VGA
 
 config MAINBOARD_DIR
 	string
@@ -47,10 +48,6 @@ config UDELAY_LAPIC_FIXED_FSB
 	int
 	default 100
 
-config VGA
-	bool
-	default y
-
 config VIRTUAL_ROM_SIZE
 	hex
 	default 0x1000000
diff --git a/src/mainboard/msi/ms9652_fam10/Kconfig b/src/mainboard/msi/ms9652_fam10/Kconfig
index e305551..359d1c5 100644
--- a/src/mainboard/msi/ms9652_fam10/Kconfig
+++ b/src/mainboard/msi/ms9652_fam10/Kconfig
@@ -49,10 +49,6 @@ config MAX_PHYSICAL_CPUS
 	int
 	default 2
 
-config LOGICAL_CPUS
-	bool
-	default y
-
 config HEAP_SIZE
 	hex
 	default 0x20000



More information about the coreboot-gerrit mailing list