[coreboot-gerrit] Patch set updated for coreboot: c3488a2 rambi: change SD card pulls to 20K

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Thu May 8 17:06:36 CEST 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4999

-gerrit

commit c3488a2496f090ed67eaa192a5261bc4347c365d
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Dec 10 09:17:18 2013 -0800

    rambi: change SD card pulls to 20K
    
    Now that the SD card controller is limited to the SD card
    2.0 spec it's possible to use 20K pulls for the pads.
    
    BUG=chrome-os-partner:24423
    BUG=chrome-os-partner:24312
    BRANCH=None
    TEST=Built and booted. Able to dd to/from /dev/mmcblk1 without
         any errors.
    
    Change-Id: Id5396c55330a84bf7a09d227507d2bfcde66a1a4
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/179423
---
 src/mainboard/google/rambi/gpio.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/google/rambi/gpio.c b/src/mainboard/google/rambi/gpio.c
index a93da53..6e6efe6 100644
--- a/src/mainboard/google/rambi/gpio.c
+++ b/src/mainboard/google/rambi/gpio.c
@@ -90,13 +90,13 @@ static const struct soc_gpio_map gpscore_gpio_map[] = {
 	GPIO_NC,	/* S0-SC030 - NC */
 	GPIO_NC,	/* S0-SC031 - NC */
 	GPIO_NC,	/* S0-SC032 - NC */
-	GPIO_FUNC(1, PULL_DOWN, 2K),	/* S0-SC033 - SD3_CLK */
-	GPIO_FUNC(1, PULL_UP, 2K),	/* S0-SC034 - SD3_D0 */
-	GPIO_FUNC(1, PULL_UP, 2K),	/* S0-SC035 - SD3_D1 */
-	GPIO_FUNC(1, PULL_UP, 2K),	/* S0-SC036 - SD3_D2 */
-	GPIO_FUNC(1, PULL_UP, 2K),	/* S0-SC037 - SD3_D3 */
+	GPIO_FUNC(1, PULL_DOWN, 20K),	/* S0-SC033 - SD3_CLK */
+	GPIO_FUNC(1, PULL_UP, 20K),	/* S0-SC034 - SD3_D0 */
+	GPIO_FUNC(1, PULL_UP, 20K),	/* S0-SC035 - SD3_D1 */
+	GPIO_FUNC(1, PULL_UP, 20K),	/* S0-SC036 - SD3_D2 */
+	GPIO_FUNC(1, PULL_UP, 20K),	/* S0-SC037 - SD3_D3 */
 	GPIO_FUNC(1, PULL_UP, 20K),	/* S0-SC038 - SD3_CD# */
-	GPIO_FUNC(1, PULL_UP, 2K),	/* S0-SC039 - SD3_CMD */
+	GPIO_FUNC(1, PULL_UP, 20K),	/* S0-SC039 - SD3_CMD */
 	GPIO_NC,	/* S0-SC040 - SDMMC3_1P8_EN - TP3 */
 	GPIO_FUNC(1, PULL_UP, 20K),	/* S0-SC041 - SDIO3_PWR_EN# */
 	GPIO_FUNC1,	/* S0-SC042 - LPC_LAD0 */



More information about the coreboot-gerrit mailing list