[coreboot-gerrit] New patch to review for coreboot: eb39845 mainboard/advantech/pcm-5820: Convert uart init to generic winbond

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Thu May 8 21:10:30 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5703

-gerrit

commit eb398454becb1af79af4c3306ee32f450df246aa
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri May 9 05:07:17 2014 +1000

    mainboard/advantech/pcm-5820: Convert uart init to generic winbond
    
    Take advantage of generic winbond early_serial init driver link-time
    symbols instead of #including model specific .c implementation.
    
    Change-Id: I2fe7ecb11e10262d11c68017a00843f99a35b734
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/advantech/pcm-5820/romstage.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/advantech/pcm-5820/romstage.c b/src/mainboard/advantech/pcm-5820/romstage.c
index b710aad..6865f1a 100644
--- a/src/mainboard/advantech/pcm-5820/romstage.c
+++ b/src/mainboard/advantech/pcm-5820/romstage.c
@@ -25,14 +25,15 @@
 #include <console/console.h>
 #include "northbridge/amd/gx1/raminit.c"
 #include "cpu/x86/bist.h"
-#include "superio/winbond/w83977f/early_serial.c"
+#include <superio/winbond/common/winbond.h>
+#include <superio/winbond/w83977f/w83977f.h>
 #include "southbridge/amd/cs5530/enable_rom.c"
 
 #define SERIAL_DEV PNP_DEV(0x3f0, W83977F_SP1)
 
 static void main(unsigned long bist)
 {
-	w83977f_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
+	winbond_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
 	console_init();
 	report_bist_failure(bist);
 	cs5530_enable_rom();



More information about the coreboot-gerrit mailing list