[coreboot-gerrit] Patch set updated for coreboot: 6d76eb6 Implement proper IT8728F PNP ops

Rudolf Marek (r.marek@assembler.cz) gerrit at coreboot.org
Tue May 13 17:18:04 CEST 2014


Rudolf Marek (r.marek at assembler.cz) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4498

-gerrit

commit 6d76eb6d60a223e1ba81f77e8917c5039afd545a
Author: Rudolf Marek <r.marek at assembler.cz>
Date:   Tue May 13 16:07:00 2014 +0200

    Implement proper IT8728F PNP ops
    
    The Asus F2A85-M has IT8306E which is a stripped down version
    of this SIO. Implement the PNP operations of the SIO.
    
    Change-Id: Ibc4f3fafc3ffb1cd799948e63be01e6924b45d6c
    Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
---
 src/superio/ite/it8728f/superio.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/superio/ite/it8728f/superio.c b/src/superio/ite/it8728f/superio.c
index ac08f72..e689b4c 100644
--- a/src/superio/ite/it8728f/superio.c
+++ b/src/superio/ite/it8728f/superio.c
@@ -23,6 +23,7 @@
 #include <device/pnp.h>
 #include <superio/conf_mode.h>
 #include <console/console.h>
+#include <pc80/keyboard.h>
 #include <stdlib.h>
 
 #include "chip.h"
@@ -31,16 +32,18 @@
 
 static void it8728f_init(device_t dev)
 {
-	struct superio_ite_it8728f_config *conf = dev->chip_info;
-
 	if (!dev->enabled)
 		return;
 
 	switch(dev->path.pnp.device) {
 	/* TODO: Might potentially need code for HWM or FDC etc. */
-    case IT8728F_EC:
+	case IT8728F_EC:
 		it8728f_hwm_ec_init(dev);
 		break;
+	case IT8728F_KBCK:
+		set_kbc_ps2_mode();
+		pc_keyboard_init();
+		break;
 	}
 }
 
@@ -53,9 +56,16 @@ static struct device_operations ops = {
 	.ops_pnp_mode     = &pnp_conf_mode_870155_aa,
 };
 
-/* TODO: incomplete */
 static struct pnp_info pnp_dev_info[] = {
+	{ &ops, IT8728F_FDC, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, {0x0ff8, 0}, },
+	{ &ops, IT8728F_SP1, PNP_IO0 | PNP_IRQ0, {0x0ff8, 0}, },
+	{ &ops, IT8728F_SP2, PNP_IO0 | PNP_IRQ0, {0x0ff8, 0}, },
+	{ &ops, IT8728F_PP, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, {0x0ffc, 0}, },
 	{ &ops, IT8728F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0, {0x0ff8, 0}, {0x0ff8, 4}, },
+	{ &ops, IT8728F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, {0x0fff, 0}, {0x0fff, 4}, },
+	{ &ops, IT8728F_KBCM, PNP_IRQ0, },
+	{ &ops, IT8728F_GPIO, PNP_IO0 | PNP_IO1 | PNP_IO2 | PNP_IRQ0, {0x0fff, 0}, {0x0ff8, 0}, {0x0ff8, 0}, },
+	{ &ops, IT8728F_IR, PNP_IO0 | PNP_IRQ0, {0x0ff8, 0}, },
 };
 
 static void enable_dev(device_t dev)



More information about the coreboot-gerrit mailing list