[coreboot-gerrit] New patch to review for coreboot: 161bc32 it8728f_hwm.c: Small fixes

Rudolf Marek (r.marek@assembler.cz) gerrit at coreboot.org
Tue May 13 17:18:05 CEST 2014


Rudolf Marek (r.marek at assembler.cz) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5729

-gerrit

commit 161bc326abb8fc079edff910157f5f82c1aa2d6e
Author: Rudolf Marek <r.marek at assembler.cz>
Date:   Tue May 13 16:46:21 2014 +0200

    it8728f_hwm.c: Small fixes
    
    Use proper include header in it8728f_hwm.c, fix format error.
    The base of HWM block starts at offset +5.
    
    Change-Id: I6855225b38bbcf5687d506bea9482c951d314684
    Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
---
 src/superio/ite/it8728f/it8728f_hwm.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/superio/ite/it8728f/it8728f_hwm.c b/src/superio/ite/it8728f/it8728f_hwm.c
index 389cfd5..fd486a8 100644
--- a/src/superio/ite/it8728f/it8728f_hwm.c
+++ b/src/superio/ite/it8728f/it8728f_hwm.c
@@ -23,13 +23,13 @@
 #include <device/device.h>
 #include <device/pnp.h>
 #include "chip.h"
-#include "ite_internal.h"
+#include "it8728f_internal.h"
 
 /*
  * FAN controller configuration register index's
  */
 #define HWM_MAIN_CTL_REG		 0x13	/* default 0x07 */
-#define HWM_CTL_REG				 0x14	/* default 0x40 */
+#define HWM_CTL_REG			 0x14	/* default 0x40 */
 #define HWM_FAN1_CTL_PWM		 0x15	/* default 0x00 */
 #define HWM_FAN2_CTL_PWM		 0x16	/* default 0x00 */
 #define HWM_FAN3_CTL_PWM		 0x17	/* default 0x00 */
@@ -50,7 +50,8 @@ void it8728f_hwm_ec_init(device_t dev)
 		printk(BIOS_WARNING, "Super I/O HWM: No HWM resource found.\n");
 		return;
 	}
-	u16 port = res->base;
+	/* I/O port for HWM is at base + 5 */
+	u16 port = res->base + 5;
 
 	printk(BIOS_INFO,
 		"ITE IT8728F Super I/O HWM: Initializing Hardware Monitor..\n");



More information about the coreboot-gerrit mailing list