[coreboot-gerrit] New patch to review for coreboot: 38ae9dd xcompile: actually use "special compile flags" idea

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Wed May 14 16:38:30 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5743

-gerrit

commit 38ae9dd381141aa0e865c0fb74ce2aef569ea698
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Wed May 14 14:28:21 2014 +0200

    xcompile: actually use "special compile flags" idea
    
    xcompile used to test for special ARM flags - that were
    empty.
    Meanwhile, -Wa,--divide, which is only useful on i386-elf
    was tested for on arm and aarch64, too
    
    Change-Id: I1a5a1bc40fa1040d0939038b073aef31c72d0c6f
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 util/xcompile/xcompile | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 81d5b3c..e256c0d 100644
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -125,22 +125,16 @@ detect_special_flags() {
 	testcc "$CC"   "$CFLAGS -fuse-ld=bfd" &&
 		CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd'
 
-	testcc "$CC"   "$CFLAGS -Wa,--divide" &&
-		CFLAGS="$CFLAGS -Wa,--divide"
 	testcc "$CC"   "$CFLAGS -fno-stack-protector"&&
 		CFLAGS="$CFLAGS -fno-stack-protector"
 	testcc "$CC"   "$CFLAGS -Wl,--build-id=none" &&
 		CFLAGS="$CFLAGS -Wl,--build-id=none"
 
 	case "$architecture" in
-	armv7 )
-		ARMFLAGS=""
-		testcc "$CC" "$CFLAGS $ARMFLAGS"&&CFLAGS="$CFLAGS $ARMFLAGS"
-			;;
-	aarch64 )
-		ARMFLAGS=""
-		testcc "$CC" "$CFLAGS $ARMFLAGS"&&CFLAGS="$CFLAGS $ARMFLAGS"
-			;;
+	x86)
+		testcc "$CC"   "$CFLAGS -Wa,--divide" &&
+			CFLAGS="$CFLAGS -Wa,--divide"
+		;;
 	esac
 }
 



More information about the coreboot-gerrit mailing list