[coreboot-gerrit] Patch merged into coreboot/master: b013fff baytrail: nvm: use proper types for checking erase

gerrit at coreboot.org gerrit at coreboot.org
Thu May 15 05:05:24 CEST 2014


the following patch was just integrated into master:
commit b013fff5a3c036864c8f545f5cf645e27100209c
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Mon Jan 13 11:39:04 2014 -0600

    baytrail: nvm: use proper types for checking erase
    
    The current byte value was being converted to an int
    when checking against literal 0xff. As the type of
    the current pointer was char (signed) it was sign
    extending the value leading to 0xffffffff != 0xff.
    Fix this by using an unsigned type and using a
    constant type for expected erase value.
    
    BUG=chrome-os-partner:24916
    BRANCH=baytrail
    TEST=Booted after chromeos-firmwareupdate. Noted that MRC
         cache doesn't think the erased region isn't erased.
    
    Change-Id: If95425fe26da050acb25f52bea060e288ad3633c
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/182154
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: http://review.coreboot.org/5044
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>


See http://review.coreboot.org/5044 for details.

-gerrit



More information about the coreboot-gerrit mailing list