[coreboot-gerrit] Patch set updated for coreboot: 8641b28 lenovo/t60: Enable dock serial port when undocked and redocked

Damien Zammit (damien@zamaudio.com) gerrit at coreboot.org
Fri May 16 11:56:21 CEST 2014


Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5761

-gerrit

commit 8641b283773ee666f65c786893678a67d4d97681
Author: Damien Zammit <damien at zamaudio.com>
Date:   Fri May 16 18:52:47 2014 +1000

    lenovo/t60: Enable dock serial port when undocked and redocked
    
    When the system is started with dock, the serial port works.
    As soon as the laptop is undocked and redocked, the serial port
    no longer works.  See below superiotool dump snippet:
    
    Upon bootup: SIO @ 0x2e
    LDN 0x03 (COM1)
    idx 30 60 61 70 71 74 75 f0
    val 01 03 f8 04 03 04 04 02
    
    Redocked:    SIO @ 0x2e
    LDN 0x03 (COM1)
    idx 30 60 61 70 71 74 75 f0
    val 00 03 f8 04 03 04 04 02
    
    Since the function dock_connect is executed every time the
    dock is reconnected, starting without a dock and then attaching
    it to a dock is now also fixed.
    
    Change-Id: Ibd97589a8c743673a55e382a5db2ba62656c595e
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
 src/mainboard/lenovo/t60/dock.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/mainboard/lenovo/t60/dock.c b/src/mainboard/lenovo/t60/dock.c
index 9921457..b01f8e8 100644
--- a/src/mainboard/lenovo/t60/dock.c
+++ b/src/mainboard/lenovo/t60/dock.c
@@ -133,6 +133,10 @@ static int dock_superio_init(void)
 	 */
 	dock_write_register(0x22, 0xa9);
 
+	/* enable serial port */
+	dock_write_register(0x07, PC87384_SP1);
+	dock_write_register(0x30, 0x01);
+
 	dock_write_register(0x07, PC87384_GPIO);
 	dock_write_register(0x60, 0x16);
 	dock_write_register(0x61, 0x20);



More information about the coreboot-gerrit mailing list