[coreboot-gerrit] Patch set updated for coreboot: 88edf5f build: allow romcc to be wrapped

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat May 17 20:03:25 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5773

-gerrit

commit 88edf5f0766e5793d69f633c405e8ef5ad01485c
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat May 17 19:05:56 2014 +0200

    build: allow romcc to be wrapped
    
    Allow ccache and scan-build to wrap romcc.
    This works a bit different from the other compilers
    because we only define it later.
    
    Change-Id: I3adce91d3dde9dd50aa6a2baad5b457744f35575
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 Makefile     | 2 +-
 Makefile.inc | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 3404a51..5c4484a 100644
--- a/Makefile
+++ b/Makefile
@@ -135,7 +135,7 @@ CCACHE:=CCACHE_COMPILERCHECK=content CCACHE_BASEDIR=$(top) $(CCACHE)
 CC := $(CCACHE) $(CC)
 HOSTCC := $(CCACHE) $(HOSTCC)
 HOSTCXX := $(CCACHE) $(HOSTCXX)
-ROMCC := $(CCACHE) $(ROMCC)
+ROMCC_BIN := $(CCACHE) $(ROMCC_BIN)
 endif
 
 strip_quotes = $(subst ",,$(subst \",,$(1)))
diff --git a/Makefile.inc b/Makefile.inc
index d098cff..529250d 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -280,8 +280,11 @@ ifeq ($(_WINCHECK),Cygwin)
 	STACK=-Wl,--stack,16384000
 endif
 
-ROMCC:= $(objutil)/romcc/romcc
-$(ROMCC): $(top)/util/romcc/romcc.c
+# this allows ccache to prepend itself
+# (ccache handling happens first)
+ROMCC_BIN= $(objutil)/romcc/romcc
+ROMCC?=$(ROMCC_BIN)
+$(ROMCC_BIN): $(top)/util/romcc/romcc.c
 	@printf "    HOSTCC     $(subst $(obj)/,,$(@)) (this may take a while)\n"
 	@# Note: Adding -O2 here might cause problems. For details see:
 	@# http://www.coreboot.org/pipermail/coreboot/2010-February/055825.html



More information about the coreboot-gerrit mailing list