[coreboot-gerrit] Patch set updated for coreboot: 95db3db drivers: Drop GbE stub drivers

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Mon May 19 01:06:23 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5777

-gerrit

commit 95db3db425df656e9c9f4e9e6004634167d6fba1
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sun May 18 09:42:46 2014 +1000

    drivers: Drop GbE stub drivers
    
    These NIC stub drivers where to initializes the Gigabit Ethernet
    adapters just enough to keep coreboot from trying to execute an option
    ROM. However this is no longer required.
    
    Change-Id: Idc44619767c631c5fcf550a5948c8947bde5e218
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/drivers/Kconfig                    |  1 -
 src/drivers/Makefile.inc               |  1 -
 src/drivers/realtek/Kconfig            |  6 -----
 src/drivers/realtek/Makefile.inc       | 20 --------------
 src/drivers/realtek/rtl8168.c          | 49 ----------------------------------
 src/mainboard/getac/p470/Kconfig       |  1 -
 src/mainboard/ibase/mb899/Makefile.inc | 20 --------------
 src/mainboard/ibase/mb899/mv88e8053.c  | 49 ----------------------------------
 src/mainboard/intel/d945gclf/Kconfig   |  1 -
 src/mainboard/kontron/986lcd-m/Kconfig |  1 -
 src/mainboard/roda/rk886ex/Kconfig     |  1 -
 src/mainboard/roda/rk9/Kconfig         |  1 -
 12 files changed, 151 deletions(-)

diff --git a/src/drivers/Kconfig b/src/drivers/Kconfig
index 1a5f8ff..874ec75 100644
--- a/src/drivers/Kconfig
+++ b/src/drivers/Kconfig
@@ -31,7 +31,6 @@ source src/drivers/parade/Kconfig
 if PC80_SYSTEM
 source src/drivers/pc80/Kconfig
 endif
-source src/drivers/realtek/Kconfig
 source src/drivers/sil/Kconfig
 source src/drivers/spi/Kconfig
 source src/drivers/ti/Kconfig
diff --git a/src/drivers/Makefile.inc b/src/drivers/Makefile.inc
index f11e4b8..66fe7b8 100644
--- a/src/drivers/Makefile.inc
+++ b/src/drivers/Makefile.inc
@@ -26,7 +26,6 @@ subdirs-y += intel
 subdirs-y += maxim
 subdirs-y += net
 subdirs-y += parade
-subdirs-y += realtek
 subdirs-y += sil
 subdirs-y += trident
 subdirs-$(CONFIG_DRIVERS_UART) += uart
diff --git a/src/drivers/realtek/Kconfig b/src/drivers/realtek/Kconfig
deleted file mode 100644
index 0799445..0000000
--- a/src/drivers/realtek/Kconfig
+++ /dev/null
@@ -1,6 +0,0 @@
-config RTL8168_ROM_DISABLE
-	bool "Disable RTL8168 ROM"
-	default n
-	help
-	  Just enough of a driver to make coreboot not look for an Option ROM.
-	  No configuration is necessary for the OS to pick up the device.
diff --git a/src/drivers/realtek/Makefile.inc b/src/drivers/realtek/Makefile.inc
deleted file mode 100644
index d7f39ac..0000000
--- a/src/drivers/realtek/Makefile.inc
+++ /dev/null
@@ -1,20 +0,0 @@
-##
-## This file is part of the coreboot project.
-##
-## Copyright (C) 2012 secunet Security Networks AG
-##
-## This program is free software; you can redistribute it and/or modify
-## it under the terms of the GNU General Public License as published by
-## the Free Software Foundation; version 2 of the License.
-##
-## This program is distributed in the hope that it will be useful,
-## but WITHOUT ANY WARRANTY; without even the implied warranty of
-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-## GNU General Public License for more details.
-##
-## You should have received a copy of the GNU General Public License
-## along with this program; if not, write to the Free Software
-## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
-##
-
-ramstage-$(CONFIG_RTL8168_ROM_DISABLE) += rtl8168.c
diff --git a/src/drivers/realtek/rtl8168.c b/src/drivers/realtek/rtl8168.c
deleted file mode 100644
index 655b72f..0000000
--- a/src/drivers/realtek/rtl8168.c
+++ /dev/null
@@ -1,49 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2008 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-/* This code should work for all ICH* southbridges with a NIC. */
-
-#include <console/console.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-
-static void nic_init(struct device *dev)
-{
-	printk(BIOS_DEBUG, "Initializing RTL8168 Gigabit Ethernet\n");
-	// Nothing to do yet, but this has to be here to keep
-	// coreboot from trying to execute an option ROM.
-}
-
-static struct device_operations nic_ops = {
-	.read_resources		= pci_dev_read_resources,
-	.set_resources		= pci_dev_set_resources,
-	.enable_resources	= pci_dev_enable_resources,
-	.init			= nic_init,
-	.scan_bus		= 0,
-};
-
-static const struct pci_driver rtl8169_nic __pci_driver = {
-	.ops	= &nic_ops,
-	.vendor	= 0x10ec,
-	.device	= 0x8168,
-};
-
-
diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig
index 3696b14..3e230ae 100644
--- a/src/mainboard/getac/p470/Kconfig
+++ b/src/mainboard/getac/p470/Kconfig
@@ -40,7 +40,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_1024
 	select GFXUMA
 	select CHANNEL_XOR_RANDOMIZATION
-	select RTL8168_ROM_DISABLE
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/ibase/mb899/Makefile.inc b/src/mainboard/ibase/mb899/Makefile.inc
deleted file mode 100644
index 4fb55f5..0000000
--- a/src/mainboard/ibase/mb899/Makefile.inc
+++ /dev/null
@@ -1,20 +0,0 @@
-##
-## This file is part of the coreboot project.
-##
-## Copyright (C) 2007-2008 coresystems GmbH
-##
-## This program is free software; you can redistribute it and/or modify
-## it under the terms of the GNU General Public License as published by
-## the Free Software Foundation; version 2 of the License.
-##
-## This program is distributed in the hope that it will be useful,
-## but WITHOUT ANY WARRANTY; without even the implied warranty of
-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-## GNU General Public License for more details.
-##
-## You should have received a copy of the GNU General Public License
-## along with this program; if not, write to the Free Software
-## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
-##
-
-ramstage-y += mv88e8053.c
diff --git a/src/mainboard/ibase/mb899/mv88e8053.c b/src/mainboard/ibase/mb899/mv88e8053.c
deleted file mode 100644
index 7db7fd8..0000000
--- a/src/mainboard/ibase/mb899/mv88e8053.c
+++ /dev/null
@@ -1,49 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2008 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-/* This code should work for all ICH* southbridges with a NIC. */
-
-#include <console/console.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-
-static void nic_init(struct device *dev)
-{
-	printk(BIOS_DEBUG, "Initializing 88E8053 Gigabit Ethernet\n");
-	// Nothing to do yet, but this has to be here to keep
-	// coreboot from trying to execute an option ROM.
-}
-
-static struct device_operations nic_ops = {
-	.read_resources		= pci_dev_read_resources,
-	.set_resources		= pci_dev_set_resources,
-	.enable_resources	= pci_dev_enable_resources,
-	.init			= nic_init,
-	.scan_bus		= 0,
-};
-
-static const struct pci_driver rtl8169_nic __pci_driver = {
-	.ops	= &nic_ops,
-	.vendor	= 0x11ab,
-	.device	= 0x4362,
-};
-
-
diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig
index 490aa80..be163cf 100644
--- a/src/mainboard/intel/d945gclf/Kconfig
+++ b/src/mainboard/intel/d945gclf/Kconfig
@@ -35,7 +35,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_512
 	select GFXUMA
 	select CHANNEL_XOR_RANDOMIZATION
-	select RTL8168_ROM_DISABLE
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig
index f5d4f8c..f5463fa 100644
--- a/src/mainboard/kontron/986lcd-m/Kconfig
+++ b/src/mainboard/kontron/986lcd-m/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select GFXUMA
 	select CHANNEL_XOR_RANDOMIZATION
 	select OVERRIDE_CLOCK_DISABLE
-	select RTL8168_ROM_DISABLE
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/roda/rk886ex/Kconfig b/src/mainboard/roda/rk886ex/Kconfig
index 94290d5..638b936 100644
--- a/src/mainboard/roda/rk886ex/Kconfig
+++ b/src/mainboard/roda/rk886ex/Kconfig
@@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_1024
 	select CHANNEL_XOR_RANDOMIZATION
 	select GFXUMA
-	select RTL8168_ROM_DISABLE
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/roda/rk9/Kconfig b/src/mainboard/roda/rk9/Kconfig
index 67fc88a..aaa7864 100644
--- a/src/mainboard/roda/rk9/Kconfig
+++ b/src/mainboard/roda/rk9/Kconfig
@@ -7,7 +7,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SOUTHBRIDGE_INTEL_I82801IX
 	select SUPERIO_SMSC_LPC47N227
 	select BOARD_ROMSIZE_KB_4096
-	select RTL8168_ROM_DISABLE
 	select DRIVERS_GENERIC_IOAPIC
 	select HAVE_MP_TABLE
 	select CARDBUS_PLUGIN_SUPPORT



More information about the coreboot-gerrit mailing list