[coreboot-gerrit] New patch to review for coreboot: 816f54b mainboard/ibase/mb899: Sanitize headers

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue May 20 23:03:02 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5796

-gerrit

commit 816f54bc915b3536c28cbadcada89aa212577c5a
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Wed May 21 06:51:15 2014 +1000

    mainboard/ibase/mb899: Sanitize headers
    
    These are not local headers.
    
    Change-Id: Ie0b0a682565a08dbfa089986dc7860fdb0846949
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/ibase/mb899/irq_tables.c | 1 -
 src/mainboard/ibase/mb899/mainboard.c  | 1 -
 src/mainboard/ibase/mb899/romstage.c   | 6 +++---
 src/mainboard/ibase/mb899/smihandler.c | 4 +---
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/mainboard/ibase/mb899/irq_tables.c b/src/mainboard/ibase/mb899/irq_tables.c
index c206bf1..9c275d5 100644
--- a/src/mainboard/ibase/mb899/irq_tables.c
+++ b/src/mainboard/ibase/mb899/irq_tables.c
@@ -58,4 +58,3 @@ unsigned long write_pirq_routing_table(unsigned long addr)
 {
 	return copy_pirq_routing_table(addr, &intel_irq_routing_table);
 }
-
diff --git a/src/mainboard/ibase/mb899/mainboard.c b/src/mainboard/ibase/mb899/mainboard.c
index f6d2456..c7b846f 100644
--- a/src/mainboard/ibase/mb899/mainboard.c
+++ b/src/mainboard/ibase/mb899/mainboard.c
@@ -225,4 +225,3 @@ static void mainboard_enable(device_t dev)
 struct chip_operations mainboard_ops = {
 	.enable_dev = mainboard_enable,
 };
-
diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c
index 067d25b..0957795 100644
--- a/src/mainboard/ibase/mb899/romstage.c
+++ b/src/mainboard/ibase/mb899/romstage.c
@@ -32,9 +32,9 @@
 #include <pc80/mc146818rtc.h>
 #include <console/console.h>
 #include <cpu/x86/bist.h>
-#include "northbridge/intel/i945/i945.h"
-#include "northbridge/intel/i945/raminit.h"
-#include "southbridge/intel/i82801gx/i82801gx.h"
+#include <northbridge/intel/i945/i945.h>
+#include <northbridge/intel/i945/raminit.h>
+#include <southbridge/intel/i82801gx/i82801gx.h>
 
 #define SERIAL_DEV PNP_DEV(0x4e, W83627EHG_SP1)
 #define DUMMY_DEV PNP_DEV(0x4e, 0)
diff --git a/src/mainboard/ibase/mb899/smihandler.c b/src/mainboard/ibase/mb899/smihandler.c
index 064109b..d1f4f7b 100644
--- a/src/mainboard/ibase/mb899/smihandler.c
+++ b/src/mainboard/ibase/mb899/smihandler.c
@@ -20,7 +20,7 @@
 #include <arch/io.h>
 #include <console/console.h>
 #include <cpu/x86/smm.h>
-#include "southbridge/intel/i82801gx/nvs.h"
+#include <southbridge/intel/i82801gx/nvs.h>
 
 /* The southbridge SMI handler checks whether gnvs has a
  * valid pointer before calling the trap handler
@@ -47,5 +47,3 @@ int mainboard_io_trap_handler(int smif)
 	//gnvs->smif = 0;
 	return 1;
 }
-
-



More information about the coreboot-gerrit mailing list