[coreboot-gerrit] New patch to review for coreboot: 27bb8ec lenovo/x60: Require only one failed boot to switch to fallback in X86_BOOTBLOCK_NORMAL mode.

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Sun May 25 11:15:51 CEST 2014


Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5856

-gerrit

commit 27bb8ec777af6ed82d3ab5802f226859b30b6f7b
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date:   Sun Oct 20 23:37:35 2013 +0200

    lenovo/x60: Require only one failed boot to switch to fallback in X86_BOOTBLOCK_NORMAL mode.
    
    src/arch/x86/Kconfig defines MAX_REBOOT_CNT as 3.
    If that value is not overrided, then the Lenovo X60 coreboot image gets it too.
    
    At the end of a successfull boot, with CONFIG_KEEP_BOOT_COUNT,
      the Lenovo X60 increments its reboot_bits cmos option by one.
    
    In case of a failed boot, the user probably doesn't know that coreboot will
      only switch to fallback after 3 failed boots, and will act as if the laptop
      will not boot anymore with its current coreboot image.
    
    Change-Id: I12a0f8f206c8be97c8ba73b3286d07f62d30e67b
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
 src/mainboard/lenovo/x60/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig
index 72aeef8..90d472c 100644
--- a/src/mainboard/lenovo/x60/Kconfig
+++ b/src/mainboard/lenovo/x60/Kconfig
@@ -54,6 +54,10 @@ config MAX_CPUS
 	int
 	default 2
 
+config MAX_REBOOT_CNT
+	int
+	default 1
+
 config MAINBOARD_SMBIOS_MANUFACTURER
 	string
 	default "LENOVO"



More information about the coreboot-gerrit mailing list