[coreboot-gerrit] New patch to review for coreboot: 0dea04b Lenovo X60: Native VGA init: Remove the framebuffer offset.

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Sun May 25 11:15:58 CEST 2014


Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5862

-gerrit

commit 0dea04b4c9deac1cdda1ba3c7ca4b8c13fcadefc
Author: Peter Stuge <peter at stuge.se>
Date:   Mon Oct 28 01:27:04 2013 +0100

    Lenovo X60: Native VGA init: Remove the framebuffer offset.
    
    Without that fix, the i915 linux kenrel driver often crash
      when it loads.
    
    That fix puts the framebuffer address at a location different from
      the one used by the i915 linux kenrel driver.
    
    Change-Id: I23569a4ef8738d71e2ba50664754c02c9aa9fc78
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
 src/mainboard/lenovo/x60/i915io.c | 6 +++---
 src/northbridge/intel/i945/gma.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/lenovo/x60/i915io.c b/src/mainboard/lenovo/x60/i915io.c
index 3552867..d38b66d 100644
--- a/src/mainboard/lenovo/x60/i915io.c
+++ b/src/mainboard/lenovo/x60/i915io.c
@@ -938,7 +938,7 @@ struct iodef iodefs[] = {
 {R, 1, "", _DSPACNTR, 0x41000000, 0},
 {W, 1, "", _DSPACNTR, 0x59000000, 0},
 {W, 1, "", _DSPASTRIDE, 0x00001000, 0},
-{W, 1, "", _DSPAADDR, 0x00020000, 0},
+{W, 1, "", _DSPAADDR, 0x00000000, 0},
 {R, 2, "", DSPARB, (DSPARB_CSTART_SHIFT & 0x4) | 0x00001d9c, 0},
 {W, 1, "", INSTPM+0x20,  FW_BLC_SELF_EN_MASK | 0x80000000, 0},
 {W, 1, "", FW_BLC, 0x011d011a, 0},
@@ -957,8 +957,8 @@ struct iodef iodefs[] = {
 {R, 2, "", _PIPEBCONF, 0x80000000, 0},
 {R, 1, "", _DSPACNTR,  0x59000000, 0},
 {W, 1, "", _DSPACNTR,  0xd9000000, 0},
-{R, 1, "", _DSPAADDR, 0x00020000, 0},
-{W, 1, "", _DSPAADDR, 0x00020000, 0},
+{R, 1, "", _DSPAADDR, 0x00000000, 0},
+{W, 1, "", _DSPAADDR, 0x00000000, 0},
 {R, 1, "", _PIPEBSTAT, 0x00000202, 0},
 {W, 1, "", _PIPEBSTAT, 0x00000202, 0},
 {R, 3, "", _PIPEBSTAT, 0x00000000, 0},
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 17761dc..5955190 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -56,7 +56,7 @@ static void gma_func0_init(struct device *dev)
 
 	iobase = dev->resource_list[1].base;
 	mmiobase = dev->resource_list[0].base;
-	graphics_base = dev->resource_list[2].base + 0x20000;
+	graphics_base = dev->resource_list[2].base;
 
 	printk(BIOS_SPEW, "GMADR=0x%08x GTTADR=0x%08x\n",
 		pci_read_config32(dev, 0x18),



More information about the coreboot-gerrit mailing list