[coreboot-gerrit] New patch to review for coreboot: 6354d8a i945: Fix regression in graphics base address.

Damien Zammit (damien@zamaudio.com) gerrit at coreboot.org
Sun May 25 12:52:25 CEST 2014


Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5868

-gerrit

commit 6354d8a99bc9be8caed8615ab139fb20bb70ccda
Author: Damien Zammit <damien at zamaudio.com>
Date:   Sun May 25 20:42:29 2014 +1000

    i945: Fix regression in graphics base address.
    
    Need to test on x60 hardware.
    
    Compile with vgarom in place but disable running the rom.
    Native init should work, and then Linux should detect the LVDS
    display due to VBT existance.
    If this works, need to insert fake VBT table and retest without vgarom.
    
    Change-Id: Ibff12f0ac007edab9a69e5f83a2df6d83d47b252
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
 src/mainboard/lenovo/x60/devicetree.cb | 4 ++--
 src/northbridge/intel/i945/gma.c       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/lenovo/x60/devicetree.cb b/src/mainboard/lenovo/x60/devicetree.cb
index 416c1f8..bb1b5b4 100644
--- a/src/mainboard/lenovo/x60/devicetree.cb
+++ b/src/mainboard/lenovo/x60/devicetree.cb
@@ -24,8 +24,8 @@ chip northbridge/intel/i945
 
 	register "gpu_hotplug" = "0x00000220"
 	register "gpu_lvds_use_spread_spectrum_clock" = "1"
-	register "gpu_lvds_is_dual_channel" = "0"
-	register "gpu_backlight" = "0x1280128"
+	register "gpu_lvds_is_dual_channel" = "1"
+	register "gpu_backlight" = "0x879F879E"
 
 	device cpu_cluster 0 on
 		chip cpu/intel/socket_mFCPGA478
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 8dd1250..fb100d6 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -413,7 +413,7 @@ static void gma_func0_init(struct device *dev)
 		pci_read_config32(dev, 0x1c)
 	);
 
-	intel_gma_init(conf, pci_read_config32(dev, 0x5c) & ~0xf,
+	intel_gma_init(conf, uma_memory_base+256*KiB,
 		       iobase, mmiobase, graphics_base);
 #endif
 



More information about the coreboot-gerrit mailing list