[coreboot-gerrit] Patch set updated for coreboot: 37a152f cpu/intel/fsp_model_206ax: change realpath to readlink

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Fri May 30 23:42:28 CEST 2014


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5793

-gerrit

commit 37a152f8a840a87609530ae860fb5f4b4886ac7b
Author: Martin Roth <gaumless at gmail.com>
Date:   Mon May 19 15:28:00 2014 -0600

    cpu/intel/fsp_model_206ax: change realpath to readlink
    
    realpath and readlink can be used to do the same thing - in this case
    we're turning path1/path2/../path3/path4 into path1/path3/path4 so
    that the makefile's wildcard routine can evaluate it.
    
    Debian derivatives don't seem to include realpath. (and even when it's
    installed, it's not the gnu coreutils version.)
    
    Change-Id: I0a80a1d9b563810bdf96aea9d5de79ce1cea457a
    Signed-off-by: Martin Roth <gaumless at gmail.com>
---
 src/cpu/intel/fsp_model_206ax/Makefile.inc        | 2 +-
 src/soc/intel/fsp_baytrail/microcode/Makefile.inc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/cpu/intel/fsp_model_206ax/Makefile.inc b/src/cpu/intel/fsp_model_206ax/Makefile.inc
index c6d7339..cb7f2a8 100644
--- a/src/cpu/intel/fsp_model_206ax/Makefile.inc
+++ b/src/cpu/intel/fsp_model_206ax/Makefile.inc
@@ -8,7 +8,7 @@ smm-$(CONFIG_HAVE_SMI_HANDLER) += finalize.c
 cpu_microcode-$(CONFIG_CPU_MICROCODE_CBFS_GENERATE)  += microcode_blob.c
 
 ifneq ($(CONFIG_MICROCODE_INCLUDE_PATH),)
-ifneq ($(wildcard $(shell realpath -L "$(top)/$(CONFIG_MICROCODE_INCLUDE_PATH)")),)
+ifneq ($(wildcard $(shell readlink -f "$(top)/$(CONFIG_MICROCODE_INCLUDE_PATH)")),)
 CPPFLAGS_common += -I$(CONFIG_MICROCODE_INCLUDE_PATH)
 endif
 endif
diff --git a/src/soc/intel/fsp_baytrail/microcode/Makefile.inc b/src/soc/intel/fsp_baytrail/microcode/Makefile.inc
index 012c712..f6ee135 100644
--- a/src/soc/intel/fsp_baytrail/microcode/Makefile.inc
+++ b/src/soc/intel/fsp_baytrail/microcode/Makefile.inc
@@ -19,7 +19,7 @@
 cpu_microcode-$(CONFIG_CPU_MICROCODE_CBFS_GENERATE) += microcode_blob.c
 
 ifneq ($(CONFIG_MICROCODE_INCLUDE_PATH),)
-ifneq ($(wildcard $(shell realpath -q -L "$(top)/$(CONFIG_MICROCODE_INCLUDE_PATH)")),)
+ifneq ($(wildcard $(shell readlink -f "$(top)/$(CONFIG_MICROCODE_INCLUDE_PATH)")),)
 CPPFLAGS_common += -I$(CONFIG_MICROCODE_INCLUDE_PATH)
 endif
 endif



More information about the coreboot-gerrit mailing list