[coreboot-gerrit] Patch merged into coreboot/master: beb0f26 superio/winbond/w83627hf: Avoid .c includes in mainboards

gerrit at coreboot.org gerrit at coreboot.org
Sat May 31 21:17:40 CEST 2014


the following patch was just integrated into master:
commit beb0f2631fe6e49e86687cc3a7cf63ce41157a45
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Apr 29 13:09:50 2014 +1000

    superio/winbond/w83627hf: Avoid .c includes in mainboards
    
    Move towards the removal of the superio model specific xxx_serial_enable
    implementation. Make remaining superio romstage parts link-time symbols
    and fix corresponding mainboards to match.
    
    The following mainboards remain unconverted as they are ROMCC:
     - mainboard/supermicro/x6dai_g
     - mainboard/supermicro/x6dhe_g
     - mainboard/supermicro/x6dhr_ig
     - mainboard/supermicro/x6dhr_ig2
    and so block the final removal of w83627hf_serial_enable().
    
    Special cases:
     - mainboard/supermicro/h8qme_fam10: Provide local pnp_ sio func
    Provide local superio pnp_ programming entry/exit functions as to avoid
    making superio implementation global symbols. Although this is not the
    proper/final solution, it does mitigate possible symbol collisions and
    allow for continued superio refactorisation.
    
    Change-Id: Iaefb25d77512503050cb38313ca90855ebb538ad
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Reviewed-on: http://review.coreboot.org/5601
    Tested-by: build bot (Jenkins)
    Reviewed-by: Kyösti Mälkki <kyosti.malkki at gmail.com>


See http://review.coreboot.org/5601 for details.

-gerrit



More information about the coreboot-gerrit mailing list