[coreboot-gerrit] New patch to review for coreboot: 0bd916a lib/lzma.c: Use header over .c include

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Nov 11 04:55:06 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7427

-gerrit

commit 0bd916a6cf48b3dbbe3558945406515f8ef79db6
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Nov 11 12:27:06 2014 +1100

    lib/lzma.c: Use header over .c include
    
    Change-Id: I904eb1703eaf4f8de1b4ec443173686c7985be12
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/lib/Makefile.inc | 6 ++----
 src/lib/lzma.c       | 3 ++-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc
index 20b0957..e416951 100644
--- a/src/lib/Makefile.inc
+++ b/src/lib/Makefile.inc
@@ -29,8 +29,7 @@ $(foreach arch,$(ARCH_SUPPORTED),\
 
 romstage-$(CONFIG_I2C_TPM) += delay.c
 romstage-y += cbfs.c cbfs_core.c
-romstage-$(CONFIG_COMPRESS_RAMSTAGE) += lzma.c
-#romstage-y += lzmadecode.c
+romstage-$(CONFIG_COMPRESS_RAMSTAGE) += lzma.c lzmadecode.c
 romstage-$(CONFIG_CACHE_AS_RAM) += ramtest.c
 
 ifeq ($(CONFIG_EARLY_CBMEM_INIT),y)
@@ -57,8 +56,7 @@ ramstage-y += fallback_boot.c
 ramstage-y += compute_ip_checksum.c
 ramstage-y += version.c
 ramstage-y += cbfs.c cbfs_core.c
-ramstage-y += lzma.c
-#ramstage-y += lzmadecode.c
+ramstage-y += lzma.c lzmadecode.c
 ramstage-y += stack.c
 ramstage-y += clog2.c
 romstage-y += clog2.c
diff --git a/src/lib/lzma.c b/src/lib/lzma.c
index 674a029..ea5f15f 100644
--- a/src/lib/lzma.c
+++ b/src/lib/lzma.c
@@ -9,11 +9,12 @@
  *
  */
 
-#include "lzmadecode.c"
 #include <console/console.h>
 #include <string.h>
 #include <lib.h>
 
+#include "lzmadecode.h"
+
 unsigned long ulzma(unsigned char * src, unsigned char * dst)
 {
 	unsigned char properties[LZMA_PROPERTIES_SIZE];



More information about the coreboot-gerrit mailing list