[coreboot-gerrit] New patch to review for coreboot: 4d34033 drivers/intel/gma/intel_dp.c: Fix printf type-specifier

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Nov 11 06:04:59 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7428

-gerrit

commit 4d340337729d9652e462b444869ff16689fcdd2a
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Nov 11 16:02:05 2014 +1100

    drivers/intel/gma/intel_dp.c: Fix printf type-specifier
    
    '%02hx' is unsigned short, where as the argument is typed as
    uint8_t and so '%02hhx' is actually correct here.
    
    Found-by: Clang
    Change-Id: I40c48dcecf12845f4708e511236184908e90fb56
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/drivers/intel/gma/intel_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/drivers/intel/gma/intel_dp.c b/src/drivers/intel/gma/intel_dp.c
index 7aca289..dc2a957 100644
--- a/src/drivers/intel/gma/intel_dp.c
+++ b/src/drivers/intel/gma/intel_dp.c
@@ -1533,7 +1533,7 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)
 		return 0;
 	}
 
-	printk(BIOS_SPEW, "DPCD: %02hx%02hx%02hx%02hx%02hx%02hx%02hx%02hx\n",
+	printk(BIOS_SPEW, "DPCD: %02hhx%02hhx%02hhx%02hhx%02hhx%02hhx%02hhx%02hhx\n",
 	       intel_dp->dpcd[0], intel_dp->dpcd[1], intel_dp->dpcd[2],
 	       intel_dp->dpcd[3], intel_dp->dpcd[4], intel_dp->dpcd[5],
 	       intel_dp->dpcd[6], intel_dp->dpcd[7]);



More information about the coreboot-gerrit mailing list