[coreboot-gerrit] New patch to review for coreboot: 35053bf northbridge/amd/amdfam10/conf.c: Remove extraneous parentheses
Edward O'Callaghan (eocallaghan@alterapraxis.com)
gerrit at coreboot.org
Wed Nov 12 07:44:26 CET 2014
Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7445
-gerrit
commit 35053bffcb7398f669b65960a7793af023af802c
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Wed Nov 12 17:42:52 2014 +1100
northbridge/amd/amdfam10/conf.c: Remove extraneous parentheses
Remove extraneous parentheses around the comparison.
Found-by: Clang
Change-Id: I882729b8fa9f32a3bb9b1524d4d8829cbb226b7d
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
src/northbridge/amd/amdfam10/conf.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/northbridge/amd/amdfam10/conf.c b/src/northbridge/amd/amdfam10/conf.c
index 971e319..a51e3ae 100644
--- a/src/northbridge/amd/amdfam10/conf.c
+++ b/src/northbridge/amd/amdfam10/conf.c
@@ -637,19 +637,18 @@ static u32 get_ht_c_index(u32 nodeid, u32 linkn, sys_info_conf_t *sysinfo)
#endif
tempreg = 3 | ((nodeid & 0x3f)<<2) | (linkn<<8);
for(ht_c_index=0; ht_c_index<32; ht_c_index++) {
- if(((sysinfo->ht_c_conf_bus[ht_c_index] & 0xfff) == tempreg)){
+ if((sysinfo->ht_c_conf_bus[ht_c_index] & 0xfff) == tempreg) {
return ht_c_index;
}
}
for(ht_c_index=0; ht_c_index<32; ht_c_index++) {
- if((sysinfo->ht_c_conf_bus[ht_c_index] == 0)){
+ if(sysinfo->ht_c_conf_bus[ht_c_index] == 0) {
return ht_c_index;
}
}
return -1;
-
}
static void store_ht_c_conf_bus(u32 nodeid, u32 linkn, u32 ht_c_index,
@@ -767,7 +766,6 @@ static void store_conf_mmio_addr(u32 nodeid, u32 linkn, u32 reg, u32 index,
static void set_io_addr_reg(device_t dev, u32 nodeid, u32 linkn, u32 reg,
u32 io_min, u32 io_max)
{
-
u32 i;
u32 tempreg;
#if CONFIG_EXT_CONF_SUPPORT
@@ -812,11 +810,10 @@ static void set_io_addr_reg(device_t dev, u32 nodeid, u32 linkn, u32 reg,
set_addr_map_reg_4_6_in_one_node(j,cfg_map_dest, io_min, io_max, 4);
}
#endif
-
}
+
static void set_mmio_addr_reg(u32 nodeid, u32 linkn, u32 reg, u32 index, u32 mmio_min, u32 mmio_max, u32 nodes)
{
-
u32 i;
u32 tempreg;
#if CONFIG_EXT_CONF_SUPPORT
More information about the coreboot-gerrit
mailing list