[coreboot-gerrit] New patch to review for coreboot: ca0632f baytrail: fix range check

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Nov 17 08:45:45 CET 2014


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7500

-gerrit

commit ca0632fdffd58c7542b677157dec30da68232bb4
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Mon Nov 17 08:45:02 2014 +0100

    baytrail: fix range check
    
    Change-Id: I59d42cd451997e141e02d99a62b84a7a2201eb31
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
 src/soc/intel/baytrail/gfx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/baytrail/gfx.c b/src/soc/intel/baytrail/gfx.c
index 9d4768f..5650d0d 100644
--- a/src/soc/intel/baytrail/gfx.c
+++ b/src/soc/intel/baytrail/gfx.c
@@ -24,6 +24,7 @@
 #include <device/pci.h>
 #include <device/pci_ids.h>
 #include <reg_script.h>
+#include <stdlib.h>
 
 #include <baytrail/gfx.h>
 #include <baytrail/iosf.h>
@@ -49,7 +50,7 @@ static void gfx_lock_pcbase(device_t dev)
 
 	gms = pci_read_config32(dev, GGC) & GGC_GSM_SIZE_MASK;
 	gms >>= 3;
-	if (gms > sizeof(gms_size_map))
+	if (gms > ARRAY_SIZE(gms_size_map))
 		return;
 	gmsize = gms_size_map[gms];
 



More information about the coreboot-gerrit mailing list