[coreboot-gerrit] Patch merged into coreboot/master: 68e4cbd tegra124: actually parse is_lvds

gerrit at coreboot.org gerrit at coreboot.org
Tue Nov 18 08:25:48 CET 2014


the following patch was just integrated into master:
commit 68e4cbd9d6c4b7bf88b0f6fc207e75d1528766ad
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Mon Nov 17 09:27:08 2014 +0100

    tegra124: actually parse is_lvds
    
    Precedence rules make the compiler optimize
    const | var ? val1 : val2; into val1. In our case this
    means not writing 2 << NV_SOR_CSTM_ROTCLK_SHIFT to the
    register and not caring about the content of is_lvds.
    
    Change-Id: I0b02c74f9445f51bfab9eeae2e8eb9480d104708
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
    Reviewed-on: http://review.coreboot.org/7501
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/7501 for details.

-gerrit



More information about the coreboot-gerrit mailing list