[coreboot-gerrit] New patch to review for coreboot: 85e4302 northbridge/amd/agesa: DEVICE_NOOP some stub functions

[Edward O'Callaghan (eocallaghan@alterapraxis.com)]

Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7534

-gerrit

commit 85e4302ffd46ceb84deabf569614707660e52208
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Nov 21 02:22:33 2014 +1100

    northbridge/amd/agesa: DEVICE_NOOP some stub functions
    
    Use 'DEVICE_NOOP' over stub functions to reduce loc and
    improve formalism.
    
    Change-Id: I9c8d608539647cce22fb1dfbe284a6043d3d23d9
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/northbridge/amd/agesa/family15/northbridge.c   | 6 +-----
 src/northbridge/amd/agesa/family15tn/northbridge.c | 7 +------
 src/northbridge/amd/agesa/family16kb/northbridge.c | 5 +----
 3 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c
index 22b195c..35dd374 100644
--- a/src/northbridge/amd/agesa/family15/northbridge.c
+++ b/src/northbridge/amd/agesa/family15/northbridge.c
@@ -463,10 +463,6 @@ static void nb_set_resources(device_t dev)
 	}
 }
 
-static void northbridge_init(struct device *dev)
-{
-}
-
 static unsigned scan_chains(device_t dev, unsigned max)
 {
 	unsigned nodeid;
@@ -494,7 +490,7 @@ static struct device_operations northbridge_operations = {
 	.read_resources	  = nb_read_resources,
 	.set_resources	  = nb_set_resources,
 	.enable_resources = pci_dev_enable_resources,
-	.init		  = northbridge_init,
+	.init		  = DEVICE_NOOP,
 	.scan_bus	  = scan_chains,
 	.enable		  = 0,
 	.ops_pci	  = 0,
diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c
index 37ae2d5..9575c12 100644
--- a/src/northbridge/amd/agesa/family15tn/northbridge.c
+++ b/src/northbridge/amd/agesa/family15tn/northbridge.c
@@ -463,16 +463,11 @@ static void nb_set_resources(device_t dev)
 	}
 }
 
-static void northbridge_init(struct device *dev)
-{
-}
-
-
 static struct device_operations northbridge_operations = {
 	.read_resources	  = nb_read_resources,
 	.set_resources	  = nb_set_resources,
 	.enable_resources = pci_dev_enable_resources,
-	.init		  = northbridge_init,
+	.init		  = DEVICE_NOOP,
 	.enable		  = 0,
 	.ops_pci	  = 0,
 };
diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c
index 2a2c841..1ffc6bf 100644
--- a/src/northbridge/amd/agesa/family16kb/northbridge.c
+++ b/src/northbridge/amd/agesa/family16kb/northbridge.c
@@ -463,9 +463,6 @@ static void set_resources(device_t dev)
 	}
 }
 
-static void northbridge_init(struct device *dev)
-{
-}
 #if 0				/* TODO: Check if needed. */
 static unsigned scan_chains(device_t dev, unsigned max)
 {
@@ -494,7 +491,7 @@ static struct device_operations northbridge_operations = {
 	.read_resources	  = read_resources,
 	.set_resources	  = set_resources,
 	.enable_resources = pci_dev_enable_resources,
-	.init		  = northbridge_init,
+	.init		  = DEVICE_NOOP,
 	//.scan_bus	  = scan_chains, /* TODO: */
 	.enable		  = 0,
 	.ops_pci	  = 0,