[coreboot-gerrit] New patch to review for coreboot: 9cedab4 to-wiki.sh: Show the same status for clones.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Nov 23 17:19:53 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7564

-gerrit

commit 9cedab47c6e79b8807691c2a83654b153883febb
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Nov 23 10:32:03 2014 +0100

    to-wiki.sh: Show the same status for clones.
    
    While it may not be the best way theoretically as theoretically only one
    of clones may fail if clones are not perfect, in practice there is more
    variance between e.g. different X60 variants than between most of the clones,
    yet we put all X60 variants together.
    Also in most cases we don't even have a way to tell the clones apart.
    
    Change-Id: I786aeed55300026fae0d9f0497d0c830a9f5e452
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 util/board_status/to-wiki/towiki.sh | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/util/board_status/to-wiki/towiki.sh b/util/board_status/to-wiki/towiki.sh
index a0b22da..3e80d44 100755
--- a/util/board_status/to-wiki/towiki.sh
+++ b/util/board_status/to-wiki/towiki.sh
@@ -209,12 +209,15 @@ EOF
 			board_nice="$(echo "$board" |sed -e "s,_, ,g;s/\(.\)/\u\1/g")";
 		fi
 
-		lastgood="$(echo "$have"| sed -n "/^$vendor\/$board:/ s,^[^:]*:,,gp")"
-
-		if ! [ -z "$clone_of" ]; then
-		    vendor_board_dir="$COREBOOT_DIR"/src/mainboard/"$clone_of";
+		venboard="$vendor/$board"
+		if [ -n "$clone_of" ]; then
+		    venboard="$clone_of"
 		fi
 
+		lastgood="$(echo "$have"| sed -n "/^$(echo "$venboard"|sed 's,/,\\/,g'):/ s,^[^:]*:,,gp")"
+
+		vendor_board_dir="$COREBOOT_DIR"/src/mainboard/"$venboard";
+
 		northbridge="$(sed -n "/^[[:space:]]*select NORTHBRIDGE_/ s,^[[:space:]]*select NORTHBRIDGE_,,p" "$vendor_board_dir/Kconfig")"
 		northbridge_nice="$(echo "$northbridge"|sed 's,AMD_AGESA_FAMILY\([0-9a-fA-F]*\)\(.*\),AMD Family \1h\2 (AGESA),g;s,AMD_FAMILY\([0-9a-fA-F]*\),AMD Family \1h,g;s,AMD_AMDFAM\([0-9a-fA-F]*\),AMD Family \1h,g;s,_, ,g;s,INTEL,Intel®,g;')"
 



More information about the coreboot-gerrit mailing list