[coreboot-gerrit] Patch set updated for coreboot: aa82a0a amd/fam10: Fix pstate configuration
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Nov 24 22:08:02 CET 2014
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7578
-gerrit
commit aa82a0a5af796d6721aafd6e92a6816c88e86c35
Author: Patrick Georgi <pgeorgi at google.com>
Date: Mon Nov 24 22:02:21 2014 +0100
amd/fam10: Fix pstate configuration
Testing for msr.hi | PS_EN_MASK doesn't make sense.
Change-Id: If3305e4255f227be4bb7a5496a625ef2a50a5808
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
src/cpu/amd/model_10xxx/fidvid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cpu/amd/model_10xxx/fidvid.c b/src/cpu/amd/model_10xxx/fidvid.c
index 4297c90..d3c67a9 100644
--- a/src/cpu/amd/model_10xxx/fidvid.c
+++ b/src/cpu/amd/model_10xxx/fidvid.c
@@ -196,7 +196,7 @@ static u8 setPStateMaxVal( device_t dev ) {
msr.hi |= PS_EN_MASK ;
wrmsr(PS_REG_BASE + i, msr);
}
- if (msr.hi | PS_EN_MASK) {
+ if (msr.hi & PS_EN_MASK) {
maxpstate = i;
}
}
More information about the coreboot-gerrit
mailing list