[coreboot-gerrit] Patch set updated for coreboot: 8aa2cba intel/sandybridge: make sure to stay in HLT until reboot
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Fri Nov 28 22:36:43 CET 2014
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7579
-gerrit
commit 8aa2cbab92da90dbbf05cdff19abdc936a5eb4c6
Author: Patrick Georgi <pgeorgi at google.com>
Date: Mon Nov 24 22:15:09 2014 +0100
intel/sandybridge: make sure to stay in HLT until reboot
It also tells the compiler that we never leave here.
Change-Id: I824569efd46b577588387b29fc7781abf8c42385
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
src/northbridge/intel/sandybridge/raminit_native.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c
index 5c1af44..9de39c6 100644
--- a/src/northbridge/intel/sandybridge/raminit_native.c
+++ b/src/northbridge/intel/sandybridge/raminit_native.c
@@ -3751,7 +3751,9 @@ void init_dram_ddr3(spd_raw_data * spds, int mobile, int min_tck,
if (!mrc_cache || mrc_cache->mrc_data_size < sizeof (ctrl)) {
/* Failed S3 resume, reset to come up cleanly */
outb(0x6, 0xcf9);
- hlt();
+ while (1) {
+ hlt();
+ }
}
memcpy(&ctrl, mrc_cache->mrc_data, sizeof (ctrl));
}
More information about the coreboot-gerrit
mailing list