[coreboot-gerrit] Patch merged into coreboot/master: 5f19eb6 ec: Use DEVICE_NOOP macro formalism over static stub func
gerrit at coreboot.org
gerrit at coreboot.org
Sat Nov 29 14:04:36 CET 2014
the following patch was just integrated into master:
commit 5f19eb6f402e3fa5c095d275f6483cf61edfb59b
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Sat Nov 29 00:03:03 2014 +1100
ec: Use DEVICE_NOOP macro formalism over static stub func
The in source comment:
/* This function avoids an error on serial console. */
refers to the resource allocator needing to find a non-NULL
function pointer else complaints of "... missing read_resources"
will be spewed.
Unfortunately/fortunately (depending on the time of day) compiler
optimisers have gotten a bit better at optimising away no-op functions
leading to the very message these stubs attempted to avoid. By using
the DEVICE_NOOP formalism that is static inlined 'suggests' (not enforces)
to the compiler to keep these symbols around.
Change-Id: I182019627b6954a4020f9f70e9c829ce3135f63c
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7598
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See http://review.coreboot.org/7598 for details.
-gerrit
More information about the coreboot-gerrit
mailing list