[coreboot-gerrit] Patch merged into coreboot/master: 7944581 edid: Fix extension parsing when EDID blob does not have any extensions.

gerrit at coreboot.org gerrit at coreboot.org
Wed Oct 1 17:24:47 CEST 2014


the following patch was just integrated into master:
commit 79445817aedacb5b1edbd6db2e3b6edab97eb5e0
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Thu Apr 3 18:35:58 2014 +0800

    edid: Fix extension parsing when EDID blob does not have any extensions.
    
    When parsing "extensions", we should skip the first EDID (main) block and start
    from offset 128 (EDID may have only main block, so an EDID without any
    extension is fine) because the header format for main block and extensions are
    different.
    
    Without this we will see "Unknown extension block" on all EDIDs, and seeing an
    error (1) return value for EDIDs without extension.
    
    Also, after the first "unknown" error is fixed, we can now collect all return
    values from parse_extension, and return an error when any of the extensions are
    wrong (not just last one).
    
    Change-Id: I0ee029ac8ec6800687cd7749e23989399e721109
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/193011
    (cherry picked from commit fdf0cc2e9573c19b550fa2b5e4e06337b114f864)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
    Reviewed-on: http://review.coreboot.org/6995
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>


See http://review.coreboot.org/6995 for details.

-gerrit



More information about the coreboot-gerrit mailing list