[coreboot-gerrit] Patch merged into coreboot/master: 35382a6 cbmem console: Locate the preram console with a symbol instead of a section.

gerrit at coreboot.org gerrit at coreboot.org
Tue Oct 7 23:41:37 CEST 2014


the following patch was just integrated into master:
commit 35382a6eeb6634c291ffb67a3c4fa7a4601a7328
Author: Gabe Black <gabeblack at google.com>
Date:   Wed Apr 2 17:57:05 2014 -0700

    cbmem console: Locate the preram console with a symbol instead of a section.
    
    On non-x86 systems, the location of the preram CBMEM console may not be in a
    predictable place relative to other things in the linker script. That makes it
    difficult to work with as its own section because the linker will complain if
    you try to move backwards as it lays out memory. If the console header is
    treated as an actual blob of memory which has to be put in the image, we'd
    have to predict where to put it so that it isn't before something with a lower
    address or after something with a higher address. Symbols, on the other hand,
    can be defined arbitrarily.
    
    Change-Id: I3257b981eee0c15bb997a9f2c55a03494c6ec6f0
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://chromium-review.googlesource.com/193164
    Reviewed-by: Tom Warren <twarren at nvidia.com>
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit a492761c27076bcac080013d509ae4aafd6dc3e3)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
    Reviewed-on: http://review.coreboot.org/7013
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>


See http://review.coreboot.org/7013 for details.

-gerrit



More information about the coreboot-gerrit mailing list