[coreboot-gerrit] Patch set updated for coreboot: 39d3e71 AMD Trinity and Kabini: fix fan control

WANG Siyuan (wangsiyuanbuaa@gmail.com) gerrit at coreboot.org
Tue Oct 14 11:26:09 CEST 2014


WANG Siyuan (wangsiyuanbuaa at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6981

-gerrit

commit 39d3e71637bcb2cfc0f7bb06ec24f7b4893d81e9
Author: WANG Siyuan <wangsiyuanbuaa at gmail.com>
Date:   Fri Oct 10 14:37:02 2014 +0800

    AMD Trinity and Kabini: fix fan control
    
    The fan can stop but can't run again. "AGESA: Call get_bus_conf() just
    once" (commit ef40ca57) results to this problem.
    This patch can resolve this problem.
    
    Change-Id: I1b5bf3f6f7a66c60743f78918dc5442cdfc8b6e4
    Signed-off-by: WANG Siyuan <SiYuan.Wang at amd.com>
    Signed-off-by: WANG Siyuan <wangsiyuanbuaa at gmail.com>
---
 src/cpu/amd/agesa/amd_late_init.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/cpu/amd/agesa/amd_late_init.c b/src/cpu/amd/agesa/amd_late_init.c
index c7927dc..9f30c2b 100644
--- a/src/cpu/amd/agesa/amd_late_init.c
+++ b/src/cpu/amd/agesa/amd_late_init.c
@@ -58,18 +58,16 @@ static void agesawrapper_post_device(void *unused)
 	pci_write_config32(dev, 0x60, value);
 #endif
 
-#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)
-	/* AMD AGESA does not enable thermal zone, so we enable it here. */
-	enable_imc_thermal_zone();
-#endif
-
 #if CONFIG_AMD_SB_CIMX
 	sb_Late_Post();
 #endif
-	if (!acpi_s3_resume_allowed())
-		return;
+	if (acpi_s3_resume_allowed())
+		AGESAWRAPPER(amdS3Save);
 
-	AGESAWRAPPER(amdS3Save);
+#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)
+	/* AMD AGESA does not enable thermal zone, so we enable it here. */
+	enable_imc_thermal_zone();
+#endif
 }
 
 BOOT_STATE_INIT_ENTRIES(agesa_bscb) = {



More information about the coreboot-gerrit mailing list