[coreboot-gerrit] New patch to review for coreboot: c2b5f08 intel/sandybridge: Make native romstage laptop/desktop friendly

Damien Zammit (damien@zamaudio.com) gerrit at coreboot.org
Tue Oct 28 21:04:34 CET 2014


Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7234

-gerrit

commit c2b5f08ca9898d6f30b582d88f8d89115ca91365
Author: Damien Zammit <damien at zamaudio.com>
Date:   Tue Oct 28 23:29:43 2014 +1100

    intel/sandybridge: Make native romstage laptop/desktop friendly
    
    Add conditional statements on CONFIG_SYSTEM_LAPTOP to detect
    mobile/desktop platform and select accordingly in native raminit.
    
    Change-Id: Ice660286a8751fb6a6f993ab003f18780acb57c0
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
 src/northbridge/intel/sandybridge/romstage.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/intel/sandybridge/romstage.c b/src/northbridge/intel/sandybridge/romstage.c
index 902d66d..9066f88 100644
--- a/src/northbridge/intel/sandybridge/romstage.c
+++ b/src/northbridge/intel/sandybridge/romstage.c
@@ -68,7 +68,11 @@ void main(unsigned long bist)
 	/* Perform some early chipset initialization required
 	 * before RAM initialization can work
 	 */
+#ifdef CONFIG_SYSTEM_LAPTOP
 	sandybridge_early_initialization(SANDYBRIDGE_MOBILE);
+#else
+	sandybridge_early_initialization(SANDYBRIDGE_DESKTOP);
+#endif
 	printk(BIOS_DEBUG, "Back from sandybridge_early_initialization()\n");
 
 	s3resume = southbridge_detect_s3_resume();
@@ -86,8 +90,11 @@ void main(unsigned long bist)
 
 	timestamp_add_now(TS_BEFORE_INITRAM);
 
+#ifdef CONFIG_SYSTEM_LAPTOP
 	init_dram_ddr3(spd, 1, TCK_800MHZ, s3resume);
-
+#else
+	init_dram_ddr3(spd, 0, TCK_800MHZ, s3resume);
+#endif
 	timestamp_add_now(TS_AFTER_INITRAM);
 	post_code(0x3c);
 



More information about the coreboot-gerrit mailing list