[coreboot-gerrit] Patch merged into coreboot/master: ea8f3b4 northbridge/intel/i945/Kconfig: Select VGA

gerrit at coreboot.org gerrit at coreboot.org
Wed Sep 24 07:58:30 CEST 2014


the following patch was just integrated into master:
commit ea8f3b4aa0029871ee36a953a927c1af081343c5
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Sep 21 12:21:36 2014 +0200

    northbridge/intel/i945/Kconfig: Select VGA
    
    Commit 0092c999 (i945: Support text mode gfx init) [1] broke building
    the Lenovo X60 with native graphics initialization by selecting
    `CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT`.
    
            CC         northbridge/intel/i945/gma.ramstage.o
        src/northbridge/intel/i945/gma.c: In function 'intel_gma_init':
        src/northbridge/intel/i945/gma.c:398:2: error: implicit declaration of function 'vga_textmode_init' [-Werror=implicit-function-declaration]
    
    Selecting the Kconfig variable VGA makes the declaration of the
    function `vga_textmode_init()` to be included by the preprocessor.
    
    [1] http://review.coreboot.org/6723
    
    Change-Id: Iecbb2898193078b8738425cea13cb7e6da508cab
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/6947
    Reviewed-by: Vladimir Serbinenko <phcoder at gmail.com>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/6947 for details.

-gerrit



More information about the coreboot-gerrit mailing list