[coreboot-gerrit] New patch to review for coreboot: dce6c49 reg_script: Fix bug in IO macros

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Mon Sep 29 23:34:01 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6999

-gerrit

commit dce6c49f24be8a07a7bbf6c1380519ee8fb81cc5
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Apr 22 11:14:12 2014 -0700

    reg_script: Fix bug in IO macros
    
    These have apparently never been used because they are
    incorrect.
    
    Change-Id: I3624cb2548a0ee3da56a2cca62ed50b0dfbf7817
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/196266
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit bc0187702061fe326422c070c592a18cd93de723)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/include/reg_script.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/include/reg_script.h b/src/include/reg_script.h
index 72e1e96..97b4fb0 100644
--- a/src/include/reg_script.h
+++ b/src/include/reg_script.h
@@ -179,11 +179,11 @@ struct reg_script {
 #define REG_IO_RMW32(reg_, mask_, value_) \
 	REG_SCRIPT_IO(RMW, 32, reg_, mask_, value_, 0)
 #define REG_IO_OR8(reg_, value_) \
-	REG_SCRIPT_IO_RMW8(_reg, 0xff, value)
+	REG_IO_RMW8(reg_, 0xff, value_)
 #define REG_IO_OR16(reg_, value_) \
-	REG_SCRIPT_IO_RMW16(_reg, 0xffff, value)
+	REG_IO_RMW16(reg_, 0xffff, value_)
 #define REG_IO_OR32(reg_, value_) \
-	REG_SCRIPT_IO_RMW32(_reg, 0xffffffff, value)
+	REG_IO_RMW32(reg_, 0xffffffff, value_)
 #define REG_IO_POLL8(reg_, mask_, value_, timeout_) \
 	REG_SCRIPT_IO(POLL, 8, reg_, mask_, value_, timeout_)
 #define REG_IO_POLL16(reg_, mask_, value_, timeout_) \



More information about the coreboot-gerrit mailing list