[coreboot-gerrit] New patch to review for coreboot: chromeos: No dependency of ChromeOS bindings against vboot firmware verification

[Paul Kocialkowski (contact@paulk.fr)]

Paul Kocialkowski (contact at paulk.fr) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11143

-gerrit

commit 935380ed10f1e5af95c216e2b2265192f1ae5ba5
Author: Paul Kocialkowski <contact at paulk.fr>
Date:   Sun Aug 9 10:23:38 2015 +0200

    chromeos: No dependency of ChromeOS bindings against vboot firmware verification
    
    Some ChromeOS bindings might be wanted without using vboot verification, so the
    CHROMEOS Kconfig option shouldn't depend on VBOOT_VERIFY_FIRMWARE.
    This allows booting Coreboot all the way up to payload from the RO firmware
    path, without jumping to a RW firmware along the way, during normal boot.
    
    However, it makes sense to select it by default.
    
    Change-Id: Ia4057a56838aa05dcf3cb250ae1a27fd91402ddb
    Signed-off-by: Paul Kocialkowski <contact at paulk.fr>
---
 src/vendorcode/google/chromeos/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig
index 2f04f24..78a969a 100644
--- a/src/vendorcode/google/chromeos/Kconfig
+++ b/src/vendorcode/google/chromeos/Kconfig
@@ -31,7 +31,6 @@ config CHROMEOS
 	select BOOTMODE_STRAPS
 	select ELOG
 	select COLLECT_TIMESTAMPS
-	select VBOOT_VERIFY_FIRMWARE
 	help
 	  Enable ChromeOS specific features like the GPIO sub table in
 	  the coreboot table. NOTE: Enabling this option on an unsupported
@@ -129,7 +128,7 @@ config VIRTUAL_DEV_SWITCH
 
 config VBOOT_VERIFY_FIRMWARE
 	bool "Verify firmware with vboot."
-	default n
+	default y
 	depends on HAVE_HARD_RESET
 	help
 	  Enabling VBOOT_VERIFY_FIRMWARE will use vboot to verify the components
@@ -163,8 +162,12 @@ config WIPEOUT_SUPPORTED
 	  signal the application the need for factory reset (a.k.a. wipe
 	  out) of the device
 
+if VBOOT_VERIFY_FIRMWARE
+
 source src/vendorcode/google/chromeos/vboot2/Kconfig
 
+endif # VBOOT_VERIFY_FIRMWARE
+
 endif # CHROMEOS
 if !CHROMEOS
 config VIRTUAL_DEV_SWITCH