[coreboot-gerrit] New patch to review for coreboot: soc/intel/common: CACHE_MRC_SETTINGS doesn't depend on HAVE_MRC

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Aug 19 18:32:56 CEST 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11288

-gerrit

commit dbc136f17babdd0bf5b29530e9cd39ee1b0b9a22
Author: Martin Roth <martinroth at google.com>
Date:   Wed Aug 19 10:23:09 2015 -0600

    soc/intel/common: CACHE_MRC_SETTINGS doesn't depend on HAVE_MRC
    
    The FSP platforms use CACHE_MRC_SETTINGS without setting HAVE_MRC,
    which caused a Kconfig warning. Since CACHE_MRC_SETTINGS doesn't really
    depend on HAVE_MRC anymore, remove the dependency in Kconfig.
    
    Fixes Kconfig warnings:
    warning: (CPU_SPECIFIC_OPTIONS && CPU_SPECIFIC_OPTIONS
    && CPU_SPECIFIC_OPTIONS && CPU_SPECIFIC_OPTIONS)
    selects CACHE_MRC_SETTINGS which has unmet direct dependencies
    (SOC_INTEL_BROADWELL && HAVE_MRC || SOC_INTEL_COMMON && HAVE_MRC)
    
    Change-Id: Id1c108f73d19cbd53b91e1671d57e7752be5d96d
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/soc/intel/common/Kconfig | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/soc/intel/common/Kconfig b/src/soc/intel/common/Kconfig
index ab8c475..954b38b 100644
--- a/src/soc/intel/common/Kconfig
+++ b/src/soc/intel/common/Kconfig
@@ -5,8 +5,6 @@ config SOC_INTEL_COMMON
 
 if SOC_INTEL_COMMON
 
-if HAVE_MRC
-
 config CACHE_MRC_SETTINGS
 	bool "Save cached MRC settings"
 	default n
@@ -34,8 +32,6 @@ config MRC_SETTINGS_PROTECT
 
 endif # CACHE_MRC_SETTINGS
 
-endif # HAVE_MRC
-
 config DISPLAY_MTRRS
 	bool "MTRRs: Display the MTRR settings"
 	default n



More information about the coreboot-gerrit mailing list